Skip to content

dim: function based subcommand handling

Jani Nikula intel-gfx 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest33 patches 1 replyIn review
  2. v1 RFC17 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/33dim: rename dim_push to dim_push_branchdim+10 -90 replies
2/33dim: rename dim_apply to dim_apply_branchdim+5 -50 replies
3/33dim: rename dim_co to dim_checkoutdim+12 -110 replies
4/33dim: rename dim_shell_checkpatch to shell_checkpatchdim+3 -30 replies
5/33dim: rename dim_checkpatch to checkpatch_commitdim+3 -30 replies
6/33dim: rename dim_checkrange to dim_checkpatchdim+3 -30 replies
7/33dim: rename setup_dim to dim_setupdim+2 -20 replies
8/33dim: rename create_workdir to dim_create_workdirdim+2 -20 replies
9/33dim: rename update_nightly to dim_rebuild_nightlydim+3 -30 replies
10/33dim: rename magic_patch to dim_magic_patchdim+2 -20 replies
11/33dim: move dim_pull_request parameter check to the functiondim+5 -40 replies
12/33dim: separate handling of aliasesdim+40 -160 replies
13/33dim: handle subcommands through functionsdim+9 -270 replies
14/33dim: add alias command to list aliasesdim dim.rst+12 -00 replies
15/33dim: abstract dim_nightly_forgetdim+9 -70 replies
16/33dim: abstract dim_update_branchesdim+22 -200 replies
17/33dim: abstract dim_for_each_workdirsdim+13 -110 replies
18/33dim: abstract dim_push_*dim+18 -120 replies
19/33dim: abstract dim_checkout callersdim+15 -90 replies
20/33dim: abstract dim apply* subcommandsdim+33 -230 replies
21/33dim: abstract dim_magic_rebase_resolvedim+10 -90 replies
22/33dim: abstract dim_cat_to_fixupdim+6 -40 replies
23/33dim: abstract dim_tcdim+16 -140 replies
24/33dim: abstract dim_fixesdim+7 -50 replies
25/33dim: abstract dim_cherry_pickdim+16 -140 replies
26/33dim: abstract dim_pull_request_*dim+18 -120 replies
27/33dim: abstract dim_update_nextdim+64 -620 replies
28/33dim: abstract dim_tag_nextdim+18 -160 replies
29/33dim: abstract dim_{create, remove}_branchdim+52 -480 replies
30/33dim: abstract dim_checkerdim+7 -50 replies
31/33dim: abstract dim_helpdim+24 -260 replies
32/33dim: show usage instead of the man page on unknown subcommandsdim+14 -30 replies
33/33dim: add -h option for usage, imrove output on unknown optionsdim+7 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [maintainer-tools PATCH v2 00/33] dim: function based subcommand handling

This is v2 of [1], with Daniel's concern regarding aliases addressed. It's much better now.

Patches 1-11 and 15-31 are mostly just mechanical renames or code movement. They explode the series so big, but I think they're easier to look at this way.

The real changes are in patches 12-14 and 32-33.

All in all this should make dim more maintainable. It's getting pretty big for a shell script.

BR,
Jani.

[1] http://mid.gmane.org/[email protected]

Jani Nikula (33):
dim: rename dim_push to dim_push_branch
dim: rename dim_apply to dim_apply_branch
dim: rename dim_co to dim_checkout
dim: rename dim_shell_checkpatch to shell_checkpatch
dim: rename dim_checkpatch to checkpatch_commit
dim: rename dim_checkrange to dim_checkpatch
dim: rename setup_dim to dim_setup
dim: rename create_workdir to dim_create_workdir
dim: rename update_nightly to dim_rebuild_nightly
dim: rename magic_patch to dim_magic_patch
dim: move dim_pull_request parameter check to the function
dim: separate handling of aliases
dim: handle subcommands through functions
dim: add alias command to list aliases
dim: abstract dim_nightly_forget
dim: abstract dim_update_branches
dim: abstract dim_for_each_workdirs
dim: abstract dim_push_*
dim: abstract dim_checkout callers
dim: abstract dim apply* subcommands
dim: abstract dim_magic_rebase_resolve
dim: abstract dim_cat_to_fixup
dim: abstract dim_tc
dim: abstract dim_fixes
dim: abstract dim_cherry_pick
dim: abstract dim_pull_request_*
dim: abstract dim_update_next
dim: abstract dim_tag_next
dim: abstract dim_{create,remove}_branch
dim: abstract dim_checker
dim: abstract dim_help
dim: show usage instead of the man page on unknown subcommands
dim: add -h option for usage, imrove output on unknown options

 dim     | 738 +++++++++++++++++++++++++++++++++++-----------------------------
 dim.rst |   5 +
 2 files changed, 415 insertions(+), 328 deletions(-)
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx