pv6: fix sticky pktinfo behaviour
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 9 repliesIn review
- v12 patches 5 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail()include/ net/ net/ | +18 | 3 replies | |
| 2/2 | ipv6/udp: use sticky pktinfo egress ifindex on connect()net/ | +3 | 4 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Hannes Frederic Sowa | David Ahern | YOSHIFUJI Hideaki |
|---|---|---|---|
| 1/2 | A-b | A-b | A-b |
| 2/2 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH net v2 0/2] pv6: fix sticky pktinfo behaviour
Currently:
ip addr add dev eth0 2001:0010::1/64
ip addr add dev eth1 2001:0020::1/64
ping6 -I eth0 2001:0020::2
do not lead to the expected results, i.e. eth1 is used as the egress interface.
This is due to two related issues in handling sticky pktinfo, used by ping6 to enforce the device binding:
- ip6_dst_lookup_flow()/ip6_dst_lookup_tail() do not really enforce flowi6_oif match
- ipv6 udp connect() just ignore flowi6_oif
These patches address each issue individually.
The kernel has never enforced the egress interface specified via the sticky pktinfo, except briefly between the commits 741a11d9e410 ("net: ipv6: Add RT6_LOOKUP_F_IFACE flag if oif is set") andd46a9d678e4c ("net: ipv6: Dont add RT6_LOOKUP_F_IFACE flag if saddr set"), but the ping6 tools was unaffected up to iputils-20100214, since before it used SO_BINDTODEVICE to enforce the egress interface.
Paolo Abeni (2):
ipv6: enforce flowi6_oif usage in ip6_dst_lookup_tail() ipv6/udp: use sticky pktinfo egress ifindex on connect()
include/net/ip6_route.h | 12 ++++++++++-- net/ipv6/datagram.c | 3 +++ net/ipv6/ip6_output.c | 6 +++++- net/ipv6/route.c | 7 +++---- 4 files changed, 21 insertions(+), 7 deletions(-)
Signature · 1 line
1.8.3.1