Active commit regression fix
Status from this message: Thanks, applied to my block tree:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest2 patches 3 repliesApplied
- v12 patches 3 repliesSuperseded
Changes in v2 from the cover letter
* Rather than allow insertion when bs->device_listtqe_prev points to a NULL entry, make sure than we follow the block scheme of enforcing bs->device_list->tqe_prev is NULL upon deletion. (Thanks Max!)
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | block: set device_list.tqe_prev to NULL on BDS removalblock.c blockdev.c include/ | +16 | 1 reply | |
| 2/2 | block: qemu-iotests - add test for snapshot, commit, snapshot bugtests/ tests/ tests/ | +139 | 1 reply |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Max Reitz |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 0/2] Active commit regression fix
Changes from v1:
* Rather than allow insertion when bs->device_listtqe_prev points to a NULL entry, make sure than we follow the block scheme of enforcing bs->device_list->tqe_prev is NULL upon deletion. (Thanks Max!)
Bug #1300209 is a regression in 2.5, introduced during the change away from bdrv_swap().
When we change the parent backing link (change_parent_backing_link), we must also accomodate non-NULL tqe_prev pointers that point to a NULL entry. Please see patch #1 for more details.
Jeff Cody (2):
block: set device_list.tqe_prev to NULL on BDS removal
block: qemu-iotests - add test for snapshot, commit, snapshot bug
block.c | 24 ++++++---- blockdev.c | 3 +- include/block/block.h | 1 + tests/qemu-iotests/143 | 114 +++++++++++++++++++++++++++++++++++++++++++++ tests/qemu-iotests/143.out | 24 ++++++++++ tests/qemu-iotests/group | 1 + 6 files changed, 155 insertions(+), 12 deletions(-) create mode 100755 tests/qemu-iotests/143 create mode 100644 tests/qemu-iotests/143.out
Signature · 1 line
1.9.3