Skip to content

Enable Virtio Over PCIe (VOP) driver

Sudeep Dutt lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 0 repliesNew
  2. v18 patches 3 repliesSuperseded

Changes in v2 from the cover letter

a) Rebased to latest char-misc-testing
b) Use default private pointer in the device structure instead of adding a new priv field as per feedback from Greg Kroah-Hartman

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8misc: mic: Remove MIC X100 host virtio functionalitydrivers/misc/mic/host/Makefile drivers/misc/mic/host/mic_boot.c drivers/misc/mic/host/mic_debugfs.c +6 more+4 -14640 replies
2/8misc: mic: Remove MIC X100 card virtio functionalitydrivers/misc/mic/card/Makefile drivers/misc/mic/card/mic_device.c drivers/misc/mic/card/mic_virtio.c +1 more+1 -7190 replies
3/8misc: mic: MIC VOP Busdrivers/misc/mic/Kconfig drivers/misc/mic/bus/Makefile drivers/misc/mic/bus/vop_bus.c +1 more+361 -00 replies
4/8misc: mic: Add data structures for the VOP driverdrivers/misc/mic/vop/vop_main.h+170 -00 replies
5/8misc: mic: Enable VOP host side functionalitydrivers/misc/mic/vop/vop_vringh.c+1164 -00 replies
6/8misc: mic: Enable VOP card side functionalitydrivers/misc/mic/vop/vop_main.c+755 -00 replies
7/8misc: mic: Enable VOP debugfs and driver builddrivers/misc/mic/Kconfig drivers/misc/mic/Makefile drivers/misc/mic/vop/Makefile +1 more+262 -00 replies
8/8misc: mic: MIC host and card driver changes to enable VOPDocumentation/mic/mic_overview.txt Documentation/mic/mpssd/mpss Documentation/mic/mpssd/mpssd.c +7 more+247 -330 replies

Reviews trailers per patch

5 of 8 patches have a Reviewed-by or Acked-by.

PatchAshutosh Dixit
1/8R-b
2/8R-b
3/8R-b
4/8
5/8
6/8
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH char-misc-testing v2 0/8] Enable Virtio Over PCIe (VOP) driver

ChangeLog:
=========
v1 => v2:
a) Rebased to latest char-misc-testing
b) Use default private pointer in the device structure instead of adding a new priv field as per feedback from Greg Kroah-Hartman

v1: Initial post @ https://lkml.org/lkml/2016/2/1/1015

Description:
============
This patch series moves virtio functionality from the MIC host/card driver into a separate hardware independent Virtio Over PCIe (VOP) driver. Apart from being moved into a separate driver the functionality is essentially unchanged. This refactoring allows this hardware independent logic to be shared easily across multiple generations of MIC devices. The original commits are listed below for reference:
- commit f69bcbf3b4c4 ("Intel MIC Host Driver Changes for Virtio Devices.") in drivers/misc/mic/host/mic_virtio.c
- commit 2141c7c5ee67 ("Intel MIC Card Driver Changes for Virtio Devices.") in drivers/misc/mic/card/mic_virtio.c

The patch series is partitioned as follows:
1) Removes MIC X100 host virtio functionality
2) Removes MIC X100 card virtio functionality
3) Enables the Virtio Over PCIe (VOP) bus which abstracts the low level hardware details like interrupts and mapping remote memory so that the same VOP driver can work without changes with different MIC host or card drivers as long as the hardware bus operations are implemented.
4) Adds data structures for the VOP driver
5) Enables VOP host side functionality
6) Enables VOP card side functionality
7) Enables VOP debugfs and driver build
8) Implements the MIC host and card driver changes to enable VOP

Ashutosh Dixit (1):
misc: mic: Enable VOP card side functionality

Sudeep Dutt (7):
misc: mic: Remove MIC X100 host virtio functionality
misc: mic: Remove MIC X100 card virtio functionality
misc: mic: MIC VOP Bus
misc: mic: Add data structures for the VOP driver
misc: mic: Enable VOP host side functionality
misc: mic: Enable VOP debugfs and driver build
misc: mic: MIC host and card driver changes to enable VOP

 Documentation/mic/mic_overview.txt                 |   54 +-
 drivers/misc/mic/Kconfig                           |   44 +-
 drivers/misc/mic/Makefile                          |    1 +
 drivers/misc/mic/bus/Makefile                      |    1 +
 drivers/misc/mic/card/Makefile                     |    1 -
 drivers/misc/mic/host/Makefile                     |    2 -
 drivers/misc/mic/vop/Makefile                      |    9 +
 drivers/misc/mic/bus/vop_bus.h                     |  140 +++
 drivers/misc/mic/card/mic_device.h                 |    3 +
 drivers/misc/mic/card/mic_virtio.h                 |   76 --
 drivers/misc/mic/host/mic_device.h                 |    9 +-
 drivers/misc/mic/host/mic_fops.h                   |   32 -
 .../misc/mic/{host/mic_virtio.h => vop/vop_main.h} |  129 ++-
 Documentation/mic/mpssd/mpssd.c                    |    2 +-
 drivers/misc/mic/bus/vop_bus.c                     |  203 ++++
 drivers/misc/mic/card/mic_device.c                 |   89 +-
 drivers/misc/mic/card/mic_virtio.c                 |  634 -----------
 drivers/misc/mic/card/mic_x100.c                   |    1 +
 drivers/misc/mic/host/mic_boot.c                   |  125 ++-
 drivers/misc/mic/host/mic_debugfs.c                |  190 ----
 drivers/misc/mic/host/mic_fops.c                   |  222 ----
 drivers/misc/mic/host/mic_main.c                   |   49 +-
 drivers/misc/mic/host/mic_virtio.c                 |  811 --------------
 drivers/misc/mic/vop/vop_debugfs.c                 |  232 ++++
 drivers/misc/mic/vop/vop_main.c                    |  755 +++++++++++++
 drivers/misc/mic/vop/vop_vringh.c                  | 1164 ++++++++++++++++++++
 Documentation/mic/mpssd/mpss                       |    2 +-
 27 files changed, 2864 insertions(+), 2116 deletions(-)
 create mode 100644 drivers/misc/mic/vop/Makefile
 create mode 100644 drivers/misc/mic/bus/vop_bus.h
 delete mode 100644 drivers/misc/mic/card/mic_virtio.h
 delete mode 100644 drivers/misc/mic/host/mic_fops.h
 rename drivers/misc/mic/{host/mic_virtio.h => vop/vop_main.h} (58%)
 create mode 100644 drivers/misc/mic/bus/vop_bus.c
 delete mode 100644 drivers/misc/mic/card/mic_virtio.c
 delete mode 100644 drivers/misc/mic/host/mic_fops.c
 delete mode 100644 drivers/misc/mic/host/mic_virtio.c
 create mode 100644 drivers/misc/mic/vop/vop_debugfs.c
 create mode 100644 drivers/misc/mic/vop/vop_main.c
 create mode 100644 drivers/misc/mic/vop/vop_vringh.c
Signature · 1 line
1.8.2.1