Skip to content

cpufreq: Fix ABBA lockdeps

Viresh Kumar linux-pm lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest6 patches 3 repliesIn review
  2. v313 patches 23 repliesSuperseded
  3. v27 patches 28 repliesSuperseded

Changes in v4 from the cover letter

- Keep only relevant patches for lockdep, will send cleanups patches separately.
- kobj_name is dropped
- Comment over update_sampling_rate is kept intact, with minor additions.
- s/global/common for common tunables

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6cpufreq: governor: Create generic macro for global tunersdrivers/cpufreq/cpufreq_conservative.c drivers/cpufreq/cpufreq_governor.h drivers/cpufreq/cpufreq_ondemand.c+28 -240 replies
2/6cpufreq: governor: Move common tunables to 'struct dbs_data'drivers/cpufreq/cpufreq_conservative.c drivers/cpufreq/cpufreq_governor.c drivers/cpufreq/cpufreq_governor.h +1 more+47 -830 replies
3/6cpufreq: governor: New sysfs show/store callbacks for governor tunablesdrivers/cpufreq/cpufreq_conservative.c drivers/cpufreq/cpufreq_governor.c drivers/cpufreq/cpufreq_governor.h +1 more+147 -1040 replies
4/6cpufreq: governor: Drop unused macros for creating governor tunable attributesdrivers/cpufreq/cpufreq_governor.h+0 -890 replies
5/6Revert "cpufreq: Drop rwsem lock around CPUFREQ_GOV_POLICY_EXIT"drivers/cpufreq/cpufreq.c include/linux/cpufreq.h+0 -90 replies
6/6cpufreq: governor: Create and traverse list of policy_dbs to fix lockdepdrivers/cpufreq/cpufreq_governor.c drivers/cpufreq/cpufreq_governor.h drivers/cpufreq/cpufreq_ondemand.c+54 -644 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchJuri LelliShilpasri G Bhat
1/6T-b T-b
2/6T-b T-b
3/6T-b T-b
4/6T-b T-b
5/6T-b T-b
6/6T-b T-b T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH V4 0/6] cpufreq: Fix ABBA lockdeps

Hi Rafael,

As suggested, I have kept only what you suggested and fixed them based on your review comments.

@Juri and Shilpa: I have also added your Tested-by's, please let me know if you don't prefer to add them here.

V3->V4:
- Keep only relevant patches for lockdep, will send cleanups patches separately.
- kobj_name is dropped
- Comment over update_sampling_rate is kept intact, with minor additions.
- s/global/common for common tunables

Viresh Kumar (6):
cpufreq: governor: Create generic macro for global tuners
cpufreq: governor: Move common tunables to 'struct dbs_data'
cpufreq: governor: New sysfs show/store callbacks for governor
tunables
cpufreq: governor: Drop unused macros for creating governor tunable
attributes
Revert "cpufreq: Drop rwsem lock around CPUFREQ_GOV_POLICY_EXIT"
cpufreq: governor: Create and traverse list of policy_dbs to fix
lockdep

 drivers/cpufreq/cpufreq.c              |   5 -
 drivers/cpufreq/cpufreq_conservative.c | 102 +++++++----------
 drivers/cpufreq/cpufreq_governor.c     | 127 ++++++++++++++-------
 drivers/cpufreq/cpufreq_governor.h     | 143 ++++++++----------------
 drivers/cpufreq/cpufreq_ondemand.c     | 194 ++++++++++++---------------------
 include/linux/cpufreq.h                |   4 -
 6 files changed, 239 insertions(+), 336 deletions(-)
Signature · 1 line
2.7.1.370.gb2aa7f8