Skip to content

drm/ticdc: Accumulated fixes over the past couple of years

Jyri Sarha dri-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest22 patches 4 repliesIn review
  2. v322 patches 6 repliesSuperseded
  3. v221 patches 3 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v121 patches2 repliesSuperseded

Changes in v4 from the cover letter

- 21/22 "drm/tilcdc: Initialize crtc->port"
- Return an error and don't use scary WARN but simple dev_err() instead
- 22/22 "drm/tilcdc: Use devm_kzalloc() and devm_kcalloc() for private data"
- Tested module loading and unloading with all relevant (and prbably some unrelevant) memory debugging option on. No problem found in the patch. However, there is something fishy either in the component framework or in the way tilcdc used, but that is another story.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/22drm/tilcdc: rewrite pixel clock calculationdrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+9 -190 replies
2/22drm/tilcdc: verify fb pitchdrivers/gpu/drm/tilcdc/tilcdc_crtc.c+31 -00 replies
3/22drm/tilcdc: adopt pinctrl supportdrivers/gpu/drm/tilcdc/tilcdc_drv.c+8 -00 replies
4/22drm/tilcdc: fix kernel panic on suspend when no hdmi monitor connecteddrivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+18 -60 replies
5/22drm/tilcdc: make frame_done interrupt active at all timesdrivers/gpu/drm/tilcdc/tilcdc_drv.c+4 -20 replies
6/22drm/tilcdc: disable the lcd controller/dma engine when suspend invokeddrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+5 -20 replies
7/22drm/tilcdc: Implement dma-buf support for tilcdcdrivers/gpu/drm/tilcdc/tilcdc_drv.c+12 -10 replies
8/22drm/tilcdc: fix build error when !CONFIG_CPU_FREQdrivers/gpu/drm/tilcdc/tilcdc_drv.c+1 -10 replies
9/22drm/tilcdc: Allocate register storage based on the actual number registersdrivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+21 -20 replies
10/22drm/tilcdc: cleanup runtime PM handlingdrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c+11 -90 replies
11/22drm/tilcdc: disable crtc on unloaddrivers/gpu/drm/tilcdc/tilcdc_drv.c+2 -00 replies
12/22drm/tilcdc: split reset to a separate functiondrivers/gpu/drm/tilcdc/tilcdc_crtc.c+14 -70 replies
13/22drm/tilcdc: remove broken error handlingdrivers/gpu/drm/tilcdc/tilcdc_crtc.c+1 -60 replies
14/22drm/tilcdc: cleanup irq handlingdrivers/gpu/drm/tilcdc/tilcdc_crtc.c+5 -40 replies
15/22drm/tilcdc: Get rid of complex ping-pong mechanismdrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c+53 -953 replies
16/22drm/tilcdc: Do not update the next frame buffer close to vertical blankdrivers/gpu/drm/tilcdc/tilcdc_crtc.c+53 -80 replies
17/22drm/tilcdc: Fix interrupt enable/disable code for version 2 tilcdcdrivers/gpu/drm/tilcdc/tilcdc_drv.c+6 -50 replies
18/22drm/tilcdc: Remove the duplicate LCDC_INT_ENABLE_SET_REG in registers[]drivers/gpu/drm/tilcdc/tilcdc_drv.c+1 -20 replies
19/22drm/tilcdc: Add prints on sync lost and FIFO underrun interruptsdrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c+10 -20 replies
20/22drm/tilcdc: Disable sync lost interrupt if it fires on every framedrivers/gpu/drm/tilcdc/tilcdc_crtc.c+20 -10 replies
21/22drm/tilcdc: Initialize crtc->portdrivers/gpu/drm/tilcdc/tilcdc_crtc.c+20 -00 replies
22/22drm/tilcdc: Use devm_kzalloc() and devm_kcalloc() for private datadrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_panel.c +1 more+21 -460 replies

Reviews trailers per patch

1 of 22 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchDave GerlachFelipe BalbiTomi Valkeinen
SeriesR-b
1/22
2/22
3/22
4/22T-b A-b
5/22T-b
6/22T-b
7/22
8/22
9/22
10/22
11/22
12/22
13/22
14/22
15/22
16/22
17/22
18/22
19/22
20/22
21/22
22/22

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/22] drm/ticdc: Accumulated fixes over the past couple of years

... and yet one more round.
Changes since v3:
- 21/22 "drm/tilcdc: Initialize crtc->port"
- Return an error and don't use scary WARN but simple dev_err() instead
- 22/22 "drm/tilcdc: Use devm_kzalloc() and devm_kcalloc() for private data"
- Tested module loading and unloading with all relevant (and prbably some unrelevant) memory debugging option on. No problem found in the patch. However, there is something fishy either in the component framework or in the way tilcdc used, but that is another story.

One more round to fix the last issues commented by Tomi Valkeinen. Changes since v2:
- 09/22 "drm/tilcdc: Allocate register storage based on the actual number registers"
- Fixed typo in the description

- 21/22 "drm/tilcdc: Initialize crtc->port"
- Changed the code to handle a port-node that is put in side a ports-node
- Removed dev_warn(), and use WARN_ON() instead
- Added more details in description

- 22/22 "Use devm_kzalloc() and devm_kcalloc() for private data"
- New patch

Changes since the first version of the series:
- Dropped: "drm/tilcdc: disable console switching during pm operations"
- Changed: "drm/tilcdc: Allocate register storage based on the actual number.."
- Reversed kcalloc() nmemb and size parameters to correct order
- Added: "drm/tilcdc: Initialize crtc->port"

We have not been too active in pushing the tilcdc fixes to mainline. This series tries to bring the mainline tilcdc upto same level with TI ti-linux tree.

Some patches that touch the same place over and over again have been squashed into one, leaving author of the last rewrite on top.

Best regards,
Jyri

Darren Etheridge (4):
drm/tilcdc: rewrite pixel clock calculation
drm/tilcdc: fix kernel panic on suspend when no hdmi monitor connected drm/tilcdc: make frame_done interrupt active at all times drm/tilcdc: disable the lcd controller/dma engine when suspend invoked

Dave Gerlach (1):
drm/tilcdc: adopt pinctrl support

Grygorii Strashko (1):
drm/tilcdc: fix build error when !CONFIG_CPU_FREQ

Jyri Sarha (8):
drm/tilcdc: Implement dma-buf support for tilcdc drm/tilcdc: Allocate register storage based on the actual number
registers
drm/tilcdc: Fix interrupt enable/disable code for version 2 tilcdc drm/tilcdc: Remove the duplicate LCDC_INT_ENABLE_SET_REG in

    registers[]

drm/tilcdc: Add prints on sync lost and FIFO underrun interrupts drm/tilcdc: Disable sync lost interrupt if it fires on every frame drm/tilcdc: Initialize crtc->port
drm/tilcdc: Use devm_kzalloc() and devm_kcalloc() for private data

Tomi Valkeinen (8):
drm/tilcdc: verify fb pitch
drm/tilcdc: cleanup runtime PM handling
drm/tilcdc: disable crtc on unload
drm/tilcdc: split reset to a separate function drm/tilcdc: remove broken error handling
drm/tilcdc: cleanup irq handling
drm/tilcdc: Get rid of complex ping-pong mechanism drm/tilcdc: Do not update the next frame buffer close to vertical
blank

 drivers/gpu/drm/tilcdc/tilcdc_crtc.c   | 313 ++++++++++++++++++++++-----------
 drivers/gpu/drm/tilcdc/tilcdc_drv.c    | 130 ++++++++------
 drivers/gpu/drm/tilcdc/tilcdc_drv.h    |   5 +-
 drivers/gpu/drm/tilcdc/tilcdc_panel.c  |  20 +--
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c |  24 +--
 5 files changed, 300 insertions(+), 192 deletions(-)
Signature · 6 lines
1.9.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel