throttle: Allow I/O bursts for a user-defined period of time
Status from this message: Thanks, applied to the block branch.
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest17 patches 3 repliesApplied
- v113 patches 7 repliesSuperseded
Changes in v2 from the cover letter
- Patch 10: Add the new parameters to qmp-commands.hx
- Patch 14: New iotest for this feature
- Patch 15: Fix typo in the API documentation
- Patch 16: New document that explains the throttling infrastructure
- Patch 17: Add myself as maintainer of the throttling code
Patches in v2 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/17 | throttle: Make throttle_compute_timer() staticinclude/ util/ | +4 | 0 replies | |
| 2/17 | throttle: Make throttle_conflicting() set errpblockdev.c include/ tests/ +1 more | +17 | 0 replies | |
| 3/17 | throttle: Make throttle_max_is_missing_limit() set errpblockdev.c include/ tests/ +1 more | +9 | 0 replies | |
| 4/17 | throttle: Make throttle_is_valid() set errpblockdev.c include/ tests/ +1 more | +7 | 0 replies | |
| 5/17 | throttle: Set always an average value when setting a maximum valuetests/ | +2 | 0 replies | |
| 6/17 | throttle: Merge all functions that check the configuration into oneblockdev.c include/ tests/ +1 more | +19 | 0 replies | |
| 7/17 | throttle: Use throttle_config_init() to initialize ThrottleConfigblockdev.c include/ tests/ +1 more | +31 | 0 replies | |
| 8/17 | throttle: Add support for burst periodsinclude/ util/ | +96 | 0 replies | |
| 9/17 | throttle: Add command-line settings to define the burst periodsblockdev.c | +37 | 0 replies | |
| 10/17 | qapi: Add burst length parameters to block_set_io_throttleblockdev.c hmp.c qapi/ +1 more | +104 | 2 replies | |
| 11/17 | qapi: Add burst length fields to BlockDeviceInfoblock/ qapi/ | +53 | 0 replies | |
| 12/17 | throttle: Check that burst_level leaks correctlytests/ | +16 | 0 replies | |
| 13/17 | throttle: Test throttle_compute_wait() during burststests/ | +22 | 0 replies | |
| 14/17 | qemu-iotests: Extend iotest 093 to test burststests/ tests/ | +53 | 0 replies | |
| 15/17 | qapi: Correct the name of the iops_rd parameterqapi/ | +1 | 0 replies | |
| 16/17 | docs: Document the throttling infrastructuredocs/ | +252 | 0 replies | |
| 17/17 | MAINTAINERS: Add myself as maintainer of the throttling codeMAINTAINERS | +9 | 0 replies |
Reviews trailers per patch
12 of 17 patches have a Reviewed-by or Acked-by.
| Patch | Kevin Wolf | Stefan Hajnoczi |
|---|---|---|
| 1/17 | R-b | R-b |
| 2/17 | R-b | R-b |
| 3/17 | R-b | R-b |
| 4/17 | R-b | R-b |
| 5/17 | R-b | R-b |
| 6/17 | R-b | R-b |
| 7/17 | R-b | R-b |
| 8/17 | R-b | |
| 9/17 | R-b | |
| 10/17 | ||
| 11/17 | R-b | |
| 12/17 | R-b | |
| 13/17 | R-b | |
| 14/17 | ||
| 15/17 | ||
| 16/17 | ||
| 17/17 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [Qemu-devel] [PATCH v2 00/17] throttle: Allow I/O bursts for a user-defined period of time
Hi,
here's a new version of the series that adds support for performing I/O bursts for a user-defined period of time. Please follow the link to the first version of the series for a complete description.
There are two important changes in this version:
a) The previous series was broken because the new parameters were missing from qmp-commands.hx. This is fixed now. [patch 10]
b) This series has new tests and documentation [patches 14 and 16]
I also added myself as maintainer of the throttling code [patch 17].
Regards,
Berto
v2:
- Patch 10: Add the new parameters to qmp-commands.hx
- Patch 14: New iotest for this feature
- Patch 15: Fix typo in the API documentation
- Patch 16: New document that explains the throttling infrastructure
- Patch 17: Add myself as maintainer of the throttling code
v1: https://lists.gnu.org/archive/html/qemu-block/2016-02/msg00210.html
- Initial version
Alberto Garcia (17):
throttle: Make throttle_compute_timer() static
throttle: Make throttle_conflicting() set errp
throttle: Make throttle_max_is_missing_limit() set errp
throttle: Make throttle_is_valid() set errp
throttle: Set always an average value when setting a maximum value
throttle: Merge all functions that check the configuration into one
throttle: Use throttle_config_init() to initialize ThrottleConfig
throttle: Add support for burst periods
throttle: Add command-line settings to define the burst periods
qapi: Add burst length parameters to block_set_io_throttle
qapi: Add burst length fields to BlockDeviceInfo
throttle: Check that burst_level leaks correctly
throttle: Test throttle_compute_wait() during bursts
qemu-iotests: Extend iotest 093 to test bursts
qapi: Correct the name of the iops_rd parameter
docs: Document the throttling infrastructure
MAINTAINERS: Add myself as maintainer of the throttling code
MAINTAINERS | 9 ++ block/qapi.c | 20 ++++ blockdev.c | 99 +++++++++++++----- docs/throttle.txt | 252 +++++++++++++++++++++++++++++++++++++++++++++ hmp.c | 12 +++ include/qemu/throttle.h | 55 +++++++--- qapi/block-core.json | 92 ++++++++++++++--- qmp-commands.hx | 25 +++-- tests/qemu-iotests/093 | 65 +++++++++--- tests/qemu-iotests/093.out | 4 +- tests/test-throttle.c | 88 ++++++++++++---- util/throttle.c | 132 ++++++++++++++++-------- 12 files changed, 708 insertions(+), 145 deletions(-) create mode 100644 docs/throttle.txt
Signature · 1 line
2.7.0