Skip to content

Replace retry logic in useradd with flock

[email protected] openembedded-core 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1useradd_base.bbclass: fix simultaneous with flockmeta/classes/useradd.bbclass meta/classes/useradd_base.bbclass+48 -1252 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] Replace retry logic in useradd with flock

From: Kai Kang <[email protected]>

Hi Ross,

We met problems that useradd fails to add users. I found it a simultaneous issue, so created this patch.

As a comparison of build time:

Without flock:
1

$ time bitbake core-image-minimal
real    38m8.625s
user    318m43.262s
sys     62m47.710s

2

$ time bitbake core-image-sato
real    54m13.065s
user    587m1.386s
sys     122m16.949s

With flock:
1

$ time bitbake core-image-minimal
real    40m55.178s
user    316m26.576s
sys     58m53.322s

2

$ time bitbake core-image-sato
real    55m11.312s
user    580m16.787s
sys     118m16.385s

The following changes since commit 36b43b233c841b3c09fc17e04686b4b758780963:

lib/oe/terminal: set workdir for konsole terminal (2016-02-14 11:42:19 +0000)

are available in the git repository at:

git://git.pokylinux.org/poky-contrib kangkai/flock
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=kangkai/flock

Kai Kang (1):
useradd_base.bbclass: fix simultaneous with flock

 meta/classes/useradd.bbclass      |   8 +-
 meta/classes/useradd_base.bbclass | 165 ++++++++++----------------------------
 2 files changed, 48 insertions(+), 125 deletions(-)
Signature · 1 line
2.6.1