Skip to content

Device delete by id

David Sterba linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/15btrfs: create a helper function to read the disk superfs/btrfs/volumes.c+52 -350 replies
2/15btrfs: create helper function __check_raid_min_devices()fs/btrfs/volumes.c+32 -190 replies
3/15btrfs: clean up and optimize __check_raid_min_device()fs/btrfs/volumes.c+19 -240 replies
4/15btrfs: create helper btrfs_find_device_by_user_input()fs/btrfs/dev-replace.c fs/btrfs/volumes.c fs/btrfs/volumes.h+23 -230 replies
5/15btrfs: make use of btrfs_find_device_by_user_input()fs/btrfs/volumes.c+37 -630 replies
6/15btrfs: enhance btrfs_find_device_by_user_input() to check device pathfs/btrfs/dev-replace.c fs/btrfs/volumes.c+3 -40 replies
7/15btrfs: make use of btrfs_scratch_superblocks() in btrfs_rm_device()fs/btrfs/volumes.c+14 -640 replies
8/15btrfs: introduce device delete by devidfs/btrfs/ioctl.c fs/btrfs/volumes.c fs/btrfs/volumes.h +1 more+73 -50 replies
9/15btrfs: optimize check for stale devicefs/btrfs/volumes.c+2 -10 replies
10/15btrfs: rename __check_raid_min_devicesfs/btrfs/volumes.c+2 -21 reply
11/15btrfs: pass number of devices to btrfs_check_raid_min_devicesfs/btrfs/volumes.c+20 -151 reply
12/15btrfs: indtroduce raid-type to error-code table, for minimum device constraintfs/btrfs/volumes.c fs/btrfs/volumes.h+16 -11 reply
13/15btrfs: use existing device constraints table btrfs_raid_arrayfs/btrfs/volumes.c+9 -141 reply
14/15btrfs: rename btrfs_find_device_by_user_inputfs/btrfs/dev-replace.c fs/btrfs/volumes.c fs/btrfs/volumes.h+13 -101 reply
15/15btrfs: rename flags for vol args v2fs/btrfs/ioctl.c include/uapi/linux/btrfs.h+8 -72 replies

Reviews trailers per patch

6 of 15 patches have a Reviewed-by or Acked-by.

PatchAnand Jain
1/15
2/15
3/15
4/15
5/15
6/15
7/15
8/15
9/15
10/15R-b
11/15R-b T-b
12/15R-b
13/15R-b
14/15R-b
15/15R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/15] Device delete by id

Hi,

this patchset extends the ioctl arugments to take an id so we can delete a device by it. It reuses the existing structure btrfs_ioctl_vol_args_v2 and extends it in na backward-compatible way so that we don't need to introduce another one.

The core patchset is from Anand, I did some cleanups as I went through the series again and made some cleanups and minor naming tweaks to the interface.

I'll add the branch to for-next and if everything goes fine I'll send a pull request for 4.6 in a week.

Anand Jain (9):
btrfs: create a helper function to read the disk super
btrfs: create helper function __check_raid_min_devices()
btrfs: clean up and optimize __check_raid_min_device()
btrfs: create helper btrfs_find_device_by_user_input()
btrfs: make use of btrfs_find_device_by_user_input()
btrfs: enhance btrfs_find_device_by_user_input() to check device path
btrfs: make use of btrfs_scratch_superblocks() in btrfs_rm_device()
btrfs: introduce device delete by devid
btrfs: optimize check for stale device

David Sterba (6):
btrfs: rename __check_raid_min_devices
btrfs: pass number of devices to btrfs_check_raid_min_devices
btrfs: indtroduce raid-type to error-code table, for minimum device
constraint
btrfs: use existing device constraints table btrfs_raid_array
btrfs: rename btrfs_find_device_by_user_input
btrfs: rename flags for vol args v2

 fs/btrfs/dev-replace.c     |  28 +---
 fs/btrfs/ioctl.c           |  58 +++++++-
 fs/btrfs/volumes.c         | 322 ++++++++++++++++++++++-----------------------
 fs/btrfs/volumes.h         |   7 +-
 include/uapi/linux/btrfs.h |  15 ++-
 5 files changed, 233 insertions(+), 197 deletions(-)
Signature · 1 line
2.7.1