Skip to content

iptunnel: scrub packet in iptunnel_pull_header

Jiri Benc netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4geneve: implement geneve_get_sk_family helperdrivers/net/geneve.c+11 -92 replies
2/4geneve: move geneve device lookup before iptunnel_pull_headerdrivers/net/geneve.c+44 -320 replies
3/4vxlan: move vxlan device lookup before iptunnel_pull_headerdrivers/net/vxlan.c+11 -120 replies
4/4iptunnel: scrub packet in iptunnel_pull_headerdrivers/net/geneve.c drivers/net/vxlan.c include/net/ip_tunnels.h +4 more+12 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/4] iptunnel: scrub packet in iptunnel_pull_header

As every IP tunnel has to scrub skb on decapsulation, iptunnel_pull_header tried to do that and open coded part of skb_scrub_packet. Various tunneling protocols (VXLAN, Geneve) then called full skb_scrub_packet on their own, duplicating part of the scrubbing already done.

Consolidate the code, calling skb_scrub_packet from iptunnel_pull_header. This will allow additional cleanups in VXLAN code, as the packet is scrubbed early during rx processing after this patchset and VXLAN can start filling out skb fields earlier.

The full picture of vxlan cleanup patches can be seen at:
https://github.com/jbenc/linux-vxlan/commits/master

Jiri Benc (4):
geneve: implement geneve_get_sk_family helper
geneve: move geneve device lookup before iptunnel_pull_header
vxlan: move vxlan device lookup before iptunnel_pull_header
iptunnel: scrub packet in iptunnel_pull_header

 drivers/net/geneve.c      | 98 +++++++++++++++++++++++++++--------------------
 drivers/net/vxlan.c       | 25 ++++++------
 include/net/ip_tunnels.h  |  3 +-
 net/ipv4/ip_gre.c         |  2 +-
 net/ipv4/ip_tunnel_core.c |  8 ++--
 net/ipv4/ipip.c           |  2 +-
 net/ipv6/sit.c            |  2 +-
 7 files changed, 76 insertions(+), 64 deletions(-)
Signature · 1 line
1.8.3.1