Skip to content

Misc patches regarding corrupt rindex handling

Bob Peterson cluster-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11libgfs2: Backport rbtree fixes from upstreamgfs2/include/osi_tree.h+30 -210 replies
2/11libgfs2: Check for obvious corruption reading rindexgfs2/libgfs2/rgrp.c gfs2/libgfs2/super.c+11 -30 replies
3/11libgfs2: Change rgrp counts to be uint64_tgfs2/edit/hexedit.c gfs2/libgfs2/gfs2l.c gfs2/libgfs2/libgfs2.h +1 more+7 -50 replies
4/11gfs2_edit: Don't reference an empty rgrp treegfs2/edit/hexedit.c+4 -20 replies
5/11fsck.gfs2: Read jindex before making rindex repairsgfs2/fsck/fs_recovery.c gfs2/fsck/fs_recovery.h gfs2/fsck/initialize.c +2 more+186 -1510 replies
6/11fsck.gfs2: better reporting of false positive rgrp identificationgfs2/fsck/rgrepair.c+7 -10 replies
7/11fsck.gfs2: Minor reformattinggfs2/fsck/rgrepair.c+9 -110 replies
8/11fsck.gfs2: Ditch variable rgcount_from_indexgfs2/fsck/rgrepair.c+2 -40 replies
9/11fsck.gfs2: Add ability to fix rindex file sizegfs2/fsck/rgrepair.c+12 -40 replies
10/11fsck.gfs2: Do not try to overrun the max rgrps that fit inside rindexgfs2/fsck/rgrepair.c+30 -70 replies
11/11fsck.gfs2: Detect multiple rgrp grow segmentsgfs2/fsck/initialize.c gfs2/fsck/rgrepair.c+160 -680 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Cluster-devel] [gfs2-utils PATCH 00/11] Misc patches regarding corrupt rindex handling

Hi,

These patches are probably best handled as separate items, rather than as a set, but I didn't want to send out 11 separate emails.

This is a collection of patches I developed while debugging some rather complex problems involving the rebuilding of corrupt or missing rindex system files by fsck.gfs2. It also fixes some problems whereby gfs2_edit or other utils crash and burn due to corrupt rindex files.

Regards,

Bob Peterson
Red Hat File Systems

---
Bob Peterson (11):
libgfs2: Backport rbtree fixes from upstream
libgfs2: Check for obvious corruption reading rindex
libgfs2: Change rgrp counts to be uint64_t
gfs2_edit: Don't reference an empty rgrp tree
fsck.gfs2: Read jindex before making rindex repairs fsck.gfs2: better reporting of false positive rgrp identification fsck.gfs2: Minor reformatting
fsck.gfs2: Ditch variable rgcount_from_index
fsck.gfs2: Add ability to fix rindex file size
fsck.gfs2: Do not try to overrun the max rgrps that fit inside rindex fsck.gfs2: Detect multiple rgrp grow segments

 gfs2/edit/hexedit.c     |   9 +-
 gfs2/fsck/fs_recovery.c | 138 +++++++++++++++++++
 gfs2/fsck/fs_recovery.h |   1 +
 gfs2/fsck/initialize.c  | 142 +-------------------
 gfs2/fsck/rgrepair.c    | 349 ++++++++++++++++++++++++++++++++++--------------
 gfs2/include/osi_tree.h |  51 ++++---
 gfs2/libgfs2/gfs2l.c    |   2 +-
 gfs2/libgfs2/libgfs2.h  |   3 +-
 gfs2/libgfs2/rgrp.c     |  30 +++--
 gfs2/libgfs2/super.c    |   8 +-
 10 files changed, 457 insertions(+), 276 deletions(-)
Signature · 1 line
2.5.0