Skip to content

toaster: clean up startup script

brian avery yocto-toaster 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1toaster: cleanup of the bin/toaster startup codebin/toaster+17 -240 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] toaster: clean up startup script

Note: This patch is against origin/master since there is an outstanding reference to meta-yocto that we need to remove from toaster-next as it is now meta-poky.

This only changes bitbake/bin/toaster which merged cleanly with toaster-next except for the above.

This cleanup fixes a couple of issues:
1) Removes the superflous code to set toasterconf.json
- this isn't used and referenced meta-yocto
- the code to set toasterconf.json is based on .templateconf
2) Changes exit to return so we don't surprise the user by exiting their shell
- this is necessary because it is being sourced
3) Removes the last references to the old TOASTER_MANAGED variable
- this is historical and no longer used.
4) Adds -t parameter to lsof
- This stops it from dying on odd filesystems and is much faster since all we are using are processes anyway
5) Handles start and stop as params
- it was easy to confuse the script especially
if we were calling it with parameters.
- if start/stop isn't specified, it will still toggle

The following changes since commit 4006a7f2762ccd5dcbc6cdff49482d4387a73261:

sanity: Fix int verses string reference (2016-02-28 22:54:09 +0000)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib bavery/toaster/fix-meta-yocto-reference
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=bavery/toaster/fix-meta-yocto-reference

brian avery (1):
toaster: cleanup of the bin/toaster startup code

 bin/toaster | 41 +++++++++++++++++------------------------
 1 file changed, 17 insertions(+), 24 deletions(-)

--
1.9.1