Skip to content

leds: Use devm_led_classdev_register

Amitoj Kaur Chawla linux-leds lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 1 replyIn review
  2. v17 patches 2 repliesSuperseded

Changes in v2 from the cover letter

-Patches 1-6: Remove unnecessary platform_set_drvdata -Patch 4: Remove unnecessary pdev_to_gpio function definition

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6leds: 88pm860x: Use devm_led_classdev_registerdrivers/leds/leds-88pm860x.c+1 -110 replies
2/6leds: lp8788: Use devm_led_classdev_registerdrivers/leds/leds-lp8788.c+1 -130 replies
3/6leds: wm831x-status: Use devm_led_classdev_registerdrivers/leds/leds-wm831x-status.c+1 -120 replies
4/6leds: s3c24xx: Use devm_led_classdev_registerdrivers/leds/leds-s3c24xx.c+1 -180 replies
5/6leds: da903x: Use devm_led_classdev_registerdrivers/leds/leds-da903x.c+1 -110 replies
6/6leds: max8997: Use devm_led_classdev_registerdrivers/leds/leds-max8997.c+1 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/6] leds: Use devm_led_classdev_register

Switch to resource-managed function devm_led_classdev_register instead of led_classdev_register and remove unneeded led_classdev_unregister.

The Coccinelle semantic patch used to make this change is as follows:
//<smpl>
@platform@
identifier p, probefn, removefn;
@@
struct platform_driver p = {
.probe = probefn,
.remove = removefn,
};

@prb@
identifier platform.probefn, pdev;
expression e;
@@
probefn(struct platform_device *pdev, ...) {
...
e =
- led_classdev_register
+ devm_led_classdev_register
(...);
...
?- led_classdev_unregister(...);
...
}
@remove depends on prb@
identifier platform.removefn;
@@
removefn(...) {
...
?- led_classdev_unregister(...);
...
}
//</smpl>

Amitoj Kaur Chawla (6):
leds: 88pm860x: Use devm_led_classdev_register
leds: lp8788: Use devm_led_classdev_register
leds: wm831x-status: Use devm_led_classdev_register
leds: s3c24xx: Use devm_led_classdev_register
leds: da903x: Use devm_led_classdev_register
leds: max8997: Use devm_led_classdev_register

Changes in v2:
-Patches 1-6: Remove unnecessary platform_set_drvdata -Patch 4: Remove unnecessary pdev_to_gpio function definition

 drivers/leds/leds-88pm860x.c      | 12 +-----------
 drivers/leds/leds-da903x.c        | 12 +-----------
 drivers/leds/leds-lp8788.c        | 14 +-------------
 drivers/leds/leds-max8997.c       | 14 +-------------
 drivers/leds/leds-s3c24xx.c       | 19 +------------------
 drivers/leds/leds-wm831x-status.c | 13 +------------
 6 files changed, 6 insertions(+), 78 deletions(-)
Signature · 1 line
1.9.1