Skip to content

Pending Cleanup patches for 4.7

Julian Calaby ath9k-devel b43-dev linux-wireless 1 version Applied

Status from this message: Thanks, applied to wireless-drivers-next.git.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 24 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/19ath9k: Remove unnecessary ?: operatordrivers/net/wireless/ath/ath9k/ar9003_eeprom.c+3 -32 replies
2/19ipw2x00: use to_pci_dev()drivers/net/wireless/intel/ipw2x00/ipw2100.c+1 -11 reply
3/19wlcore: use to_delayed_work()drivers/net/wireless/ti/wlcore/main.c drivers/net/wireless/ti/wlcore/ps.c drivers/net/wireless/ti/wlcore/scan.c+7 -70 replies
4/19wl1251: use to_delayed_work()drivers/net/wireless/ti/wl1251/ps.c+1 -10 replies
5/19rtlwifi: use to_delayed_work()drivers/net/wireless/realtek/rtlwifi/wifi.h+1 -11 reply
6/19ath9k_htc: Delete unnecessary variable initialisationdrivers/net/wireless/ath/ath9k/hif_usb.c+1 -10 replies
7/19brcmfmac: Delete unnecessary variable initialisationdrivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c+1 -10 replies
8/19iwlegacy: Return directly if allocation fails in il_eeprom_init()drivers/net/wireless/intel/iwlegacy/common.c+3 -54 replies
9/19iwl4965: Fix a null pointer dereference in il_tx_queue_free and il_cmd_queue_freedrivers/net/wireless/intel/iwlegacy/common.c+10 -40 replies
10/19b43: Fix memory leaks in b43_bus_dev_ssb_init and b43_bus_dev_bcma_initdrivers/net/wireless/broadcom/b43/main.c+4 -20 replies
11/19rtl818x_pci: Disable pci device in error handling codedrivers/net/wireless/realtek/rtl818x/rtl8180/dev.c+3 -10 replies
12/19rsi: Delete unnecessary variable initialisationdrivers/net/wireless/rsi/rsi_91x_pkt.c+4 -40 replies
13/19rsi: Delete unnecessary variable initialisationdrivers/net/wireless/rsi/rsi_91x_pkt.c+4 -42 replies
14/19rtl818x_pci: Fix a memory leak in rtl8180_init_rx_ringdrivers/net/wireless/realtek/rtl818x/rtl8180/dev.c+4 -04 replies
15/19rsi: Move variable initialisation into error codedrivers/net/wireless/rsi/rsi_91x_pkt.c+4 -20 replies
16/19rtlwifi: Implement 'rtl_addr_delay()' with a switch statementdrivers/net/wireless/realtek/rtlwifi/core.c+14 -62 replies
17/19iwl4965: Fix a memory leak in error handling code of __il4965_updrivers/net/wireless/intel/iwlegacy/4965-mac.c+1 -03 replies
18/19iwl4965: Fix more memory leaks in __il4965_up()drivers/net/wireless/intel/iwlegacy/4965-mac.c+2 -02 replies
19/19iwlegacy: Rename label in il_eeprom_init()drivers/net/wireless/intel/iwlegacy/common.c+2 -24 replies

Reviews trailers per patch

9 of 19 patches have a Reviewed-by or Acked-by.

PatchOleksij RempelArend van SprielStanislaw GruszkaSudip MukherjeeAndrea MerelloLarry FingerStanislav Yakovlev
1/19
2/19A-b
3/19
4/19
5/19A-b
6/19R-b
7/19A-b
8/19A-b
9/19A-b
10/19T-b
11/19A-b
12/19
13/19
14/19
15/19
16/19
17/19A-b
18/19A-b
19/19

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 7 reviewers.

Read the v1 thread

Cover letter [ath9k-devel] [PATCH 00/19] Pending Cleanup patches for 4.7

Hi Kalle,

This is a set of all patches in patchwork which were pending when the 4.6 merge window opened that meet the following criteria:

1. They're sane
2. They're either obviously correct, I can review them, or they've been reviewed or ACK'd by someone else.
3. They don't require any code changes to make them applyable.

That said, if anyone doesn't like any of these patches for any reason, just give me a reason and I'll drop it.

I've split the pending patches into 4 sets as detailed below. All patches have been rebased to apply in order on wireless-drivers-next at wireless-drivers-next-for-davem-2016-03-14.

Git tree: https://github.com/SkUrRiEr/wireless-drivers-pending

Tags are listed below. Note that the tags stack, so applying pending-cleanup-detail-4.6 will get you all of pending-cleanup-4.6.

By "4.6" I mean these patches were deferred when 4.6's merge window opened. As there's nothing urgent here, I expect all of them to be applied to 4.7 at the earliest. If this is version convention is stupid or confusing, I'll change it to match the version I expect it to be applied to and re-send this cover letter.

1. Cleanup:

These are the patches that just got lost or forgotten about. Nothing here should be controversial at all, the only changes required were re-writing commit messages for Markus Elfring's patches and a couple of others. There's also a b43 change that stalled waiting for someone to test it on BCMA.

branch: pending-cleanup
tag: pending-cleanup-4.6
bundle url: http://patchwork.kernel.org/bundle/skurrier/pending-cleanup%204.6/

2. Detail:

Patches that required a detailed review. This is two patches from Markus Elfring which removed many unnecessary variable initialisations. Dan Carpenter baulked at reviewing these. I've rewritten the commit messages to go into detail as to how and where the variables are used and am confident they are correct.

branch: pending-cleanup-detail
tag: pending-cleanup-detail-4.6
bundle url: http://patchwork.kernel.org/bundle/skurrier/pending-cleanup-detail%204.6/

3. More Work:

Patches that either needed the good bits split out or only fix part of the problem and need some followup. I've written notes for each change and added a patch where the additional requirements were obvious.

branch: pending-cleanup-morework
tag: pending-cleanup-morework-4.6
bundle url: http://patchwork.kernel.org/bundle/skurrier/pending-cleanup-morework%204.6/

4. Controversial:

A patch from Markus Elfring which people hated, however it fits my criteria. I don't care if it gets applied or not.

branch: pending-cleanup-controversial
tag: pending-cleanup-controversial-4.6
bundle url: http://patchwork.kernel.org/bundle/skurrier/pending-cleanup-controversial%204.6/

At this point, everything in patchwork that's deferred is either:
1. Unreviewable by me (I poked the authors of most of the older patches yesterday)
2. An earlier version of a patch I picked up
3. Too "new" (less than a couple of months old)

(My appologies for the huge CC list, scripts/get_maintainer.pl --git can
be somewhat verbose and I'm sending this to everyone who's getting an email as part of this series.)

Patches:

Byeoungwook Kim (1):
rtlwifi: Implement 'rtl_addr_delay()' with a switch statement

Geliang Tang (4):
ipw2x00: use to_pci_dev()
wlcore: use to_delayed_work()
wl1251: use to_delayed_work()
rtlwifi: use to_delayed_work()

Ivan Safonov (1):
ath9k: Remove unnecessary ?: operator

Jia-Ju Bai (5):
iwl4965: Fix a null pointer dereference in il_tx_queue_free and
il_cmd_queue_free
b43: Fix memory leaks in b43_bus_dev_ssb_init and

    b43_bus_dev_bcma_init

rtl818x_pci: Disable pci device in error handling code
rtl818x_pci: Fix a memory leak in rtl8180_init_rx_ring
iwl4965: Fix a memory leak in error handling code of __il4965_up

Julian Calaby (1):
iwl4965: Fix more memory leaks in __il4965_up()

Markus Elfring (7):
ath9k_htc: Delete unnecessary variable initialisation
brcmfmac: Delete unnecessary variable initialisation
iwlegacy: Return directly if allocation fails in il_eeprom_init()
rsi: Delete unnecessary variable initialisation
rsi: Delete unnecessary variable initialisation
rsi: Move variable initialisation into error code
iwlegacy: Rename label in il_eeprom_init()

 drivers/net/wireless/ath/ath9k/ar9003_eeprom.c     |  6 ++---
 drivers/net/wireless/ath/ath9k/hif_usb.c           |  2 +-
 drivers/net/wireless/broadcom/b43/main.c           |  6 +++--
 .../wireless/broadcom/brcm80211/brcmfmac/sdio.c    |  2 +-
 drivers/net/wireless/intel/ipw2x00/ipw2100.c       |  2 +-
 drivers/net/wireless/intel/iwlegacy/4965-mac.c     |  3 +++
 drivers/net/wireless/intel/iwlegacy/common.c       | 26 +++++++++++++---------
 drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c |  8 ++++++-
 drivers/net/wireless/realtek/rtlwifi/core.c        | 20 ++++++++++++-----
 drivers/net/wireless/realtek/rtlwifi/wifi.h        |  2 +-
 drivers/net/wireless/rsi/rsi_91x_pkt.c             | 22 +++++++++---------
 drivers/net/wireless/ti/wl1251/ps.c                |  2 +-
 drivers/net/wireless/ti/wlcore/main.c              | 10 ++++-----
 drivers/net/wireless/ti/wlcore/ps.c                |  2 +-
 drivers/net/wireless/ti/wlcore/scan.c              |  2 +-
 15 files changed, 70 insertions(+), 45 deletions(-)
Signature · 1 line
2.7.0