jfs: logging neatening
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | jfs: Remove terminating newlines from jfs_info, jfs_warn, jfs_err usesfs/ fs/ fs/ +1 more | +7 | 0 replies | |
| 2/3 | jfs: Remove unnecessary line continuations and terminating newlinesfs/ | +2 | 0 replies | |
| 3/3 | jfs: Coalesce some formatsfs/ fs/ fs/ +3 more | +20 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] jfs: logging neatening
This patchset fixes the uses of jfs_info, jfs_warn and jfs_err that have terminating newlines and a couple other trivialities to make the logging a bit more consistent.
There is a difference in use between jfs_error and the other jfs_info, jfs_warn, and jfs_err logging macros. jfs_error is more like the rest of the kernel and requires a newline as the last character of the format.
The jfs_info, jfs_warn, and jfs_err macros add the terminating newline to the format so the uses do not require them.
It is a habituated style for many people to add the terminating newline for many people and this difference in use between the various macro styles causes trivial defects in logging output.
It might be better if the jfs_info, jfs_warn, and jfs_err macros were changed to require a newline termination and the uses changed to include the newline, but that's a larger change.
Joe Perches (3):
jfs: Remove terminating newlines from jfs_info, jfs_warn, jfs_err uses
jfs: Remove unnecessary line continuations and terminating newlines
jfs: Coalesce some formats
fs/jfs/inode.c | 4 ++-- fs/jfs/jfs_discard.c | 6 ++---- fs/jfs/jfs_dtree.c | 10 ++++------ fs/jfs/jfs_imap.c | 3 +-- fs/jfs/jfs_inode.c | 2 +- fs/jfs/jfs_logmgr.c | 14 ++++++-------- fs/jfs/jfs_txnmgr.c | 21 +++++++++------------ fs/jfs/namei.c | 4 ++-- fs/jfs/super.c | 4 ++-- 9 files changed, 29 insertions(+), 39 deletions(-)
Signature · 1 line
2.8.0.rc4.16.g56331f8