Validate custom image names correctly
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | toaster: only prevent duplicate custom image names within a projectbitbake/ bitbake/ | +24 | 0 replies | |
| 2/4 | toaster: prevent exception when Project.release is nullbitbake/ | +11 | 0 replies | |
| 3/4 | toaster-tests: add tests for new custom image pagebitbake/ | +160 | 0 replies | |
| 4/4 | toaster-tests: make helper click on input before entering textbitbake/ | +5 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/4] Validate custom image names correctly
We currently validate the name of a new custom image across all projects. This means you can't use the same custom image name in multiple projects.
Modify the code to do validation correctly, and add UI tests to verify.
To test:
1. Create a project.
2. Create a custom image with name 'goo' in this project; it should work.
3. Try to create another custom image called 'goo' in this project; it should fail.
4. Try to create a custom image called 'core-image-minimal' in this project; it should fail.
5. Create another project.
6. Create a custom image called 'goo' in the second project; it should work.
The following changes since commit 4bb6fb30b0d660eaeaf4af134b99b2feaf0b3db2:
toaster: fixes for customimage package not found (2016-04-08 09:38:50 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib elliot/toaster/recipe_name_validation-9209
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/recipe_name_validation-9209
Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=9209
Elliot Smith (4):
toaster: only prevent duplicate custom image names within a project
toaster: prevent exception when Project.release is null
toaster-tests: add tests for new custom image page
toaster-tests: make helper click on input before entering text
bitbake/lib/toaster/orm/models.py | 16 ++- .../lib/toaster/tests/browser/selenium_helpers.py | 6 +- .../tests/browser/test_new_custom_image_page.py | 160 +++++++++++++++++++++ .../toastergui/static/js/newcustomimage_modal.js | 8 +- bitbake/lib/toaster/toastergui/views.py | 33 +++-- 5 files changed, 200 insertions(+), 23 deletions(-) create mode 100644 bitbake/lib/toaster/tests/browser/test_new_custom_image_page.py
--
1.9.3
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.