Skip to content

drm/tilcdc: Atomic modeset support

Jyri Sarha dri-devel 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest21 patches 0 repliesNew
  2. v1 RFC11 patches 15 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21drm/tilcdc: Fix tilcdc component master unloadingdrivers/gpu/drm/tilcdc/tilcdc_drv.c+13 -90 replies
2/21drm/tilcdc: Make tilcdc_crtc_page_flip() publicdrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+5 -10 replies
3/21drm/tilcdc: Make tilcdc_crtc_page_flip() work if crtc is not yet ondrivers/gpu/drm/tilcdc/tilcdc_crtc.c+13 -80 replies
4/21drm/tilcdc: Add dummy primary plane implementationdrivers/gpu/drm/tilcdc/Makefile drivers/gpu/drm/tilcdc/tilcdc_drv.h drivers/gpu/drm/tilcdc/tilcdc_plane.c+136 -00 replies
5/21drm/tilcdc: Initialize dummy primary plane from crtc initdrivers/gpu/drm/tilcdc/tilcdc_crtc.c+10 -10 replies
6/21drm/tilcdc: Add tilcdc_crtc_mode_set_nofb()drivers/gpu/drm/tilcdc/tilcdc_crtc.c+172 -00 replies
7/21drm/tilcdc: Add tilcdc_crtc_atomic_check()drivers/gpu/drm/tilcdc/tilcdc_crtc.c+27 -00 replies
8/21drm/tilcdc: Add atomic mode config funcsdrivers/gpu/drm/tilcdc/tilcdc_drv.c+71 -00 replies
9/21drm/tilcdc: Add drm_mode_config_reset() call to tilcdc_load()drivers/gpu/drm/tilcdc/tilcdc_drv.c+3 -00 replies
10/21drm/tilcdc: Set DRIVER_ATOMIC and use atomic crtc helpersdrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c+14 -80 replies
11/21drm/tilcdc: Remove obsolete crtc helper functionsdrivers/gpu/drm/tilcdc/tilcdc_crtc.c+0 -2080 replies
12/21drm/tilcdc: Remove tilcdc_verify_fb()drivers/gpu/drm/tilcdc/tilcdc_crtc.c+0 -210 replies
13/21drm/tilcdc: panel: Set crtc panel info at init phasedrivers/gpu/drm/tilcdc/tilcdc_panel.c+3 -20 replies
14/21drm/tilcdc: panel: Add atomic modeset helpers to connector funcsdrivers/gpu/drm/tilcdc/tilcdc_panel.c+5 -10 replies
15/21drm/tilcdc: tfp410: Set crtc panel info at init phasedrivers/gpu/drm/tilcdc/tilcdc_tfp410.c+1 -10 replies
16/21drm/tilcdc: tfp410: Add atomic modeset helpers to connector funcsdrivers/gpu/drm/tilcdc/tilcdc_tfp410.c+5 -10 replies
17/21drm/tilcdc: Enable and disable interrupts in crtc start() and stop()drivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c+39 -480 replies
18/21drm/tilcdc: Use drm_atomic_helper_resume/suspend()drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+9 -530 replies
19/21drm/tilcdc: Get rid of legacy dpms mechanismdrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+50 -700 replies
20/21drm/tilcdc: Remove unnecessary pm_runtime_get() and *_put() callsdrivers/gpu/drm/tilcdc/tilcdc_crtc.c+0 -80 replies
21/21drm/tilcdc: Change tilcdc_crtc_page_flip() to tilcdc_crtc_update_fb()drivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.h drivers/gpu/drm/tilcdc/tilcdc_plane.c+6 -90 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/21] drm/tilcdc: Atomic modeset support

This series implements atomic modeset for TI's LCDC HW. The code has been tested on X-server, weston, and our kmsxx kms testing suite. The patches are based on my earlier tilcdc fixes and cleanups series [1].

I know that the tiny display pipe has been accepted for mainline and I have intention of moving lcdc on top of it at some point. However, there is just too many things I would still have to reimplemet to do it now. How to deal with different encoders, connectors and panels for example. This series should be considered as a first step towards making that move. It implements many things that are needed in simple display pipe too.

There is a lot of changes since RFC version of the series and this is not a complete list:

- Added patches
- drm/tilcdc: Fix tilcdc component master unloading
- drm/tilcdc: Make tilcdc_crtc_page_flip() work if crtc is not yet on
- drm/tilcdc: panel: Set crtc panel info at init phase
- drm/tilcdc: panel: Add atomic modeset helpers to connector funcs
- drm/tilcdc: tfp410: Set crtc panel info at init phase
- drm/tilcdc: tfp410: Add atomic modeset helpers to connector funcs
- drm/tilcdc: Enable and disable interrupts in crtc start() and stop()
- drm/tilcdc: Use drm_atomic_helper_resume/suspend()
- drm/tilcdc: Get rid of legacy dpms mechanism
- drm/tilcdc: Remove unnecessary pm_runtime_get() and *_put() calls
- drm/tilcdc: Change tilcdc_crtc_page_flip() to tilcdc_crtc_update_fb()
- At least following changes to the "old" patches
- Add mechanism to update crtc state's mode_changed if plane fb pixel_format changes
- Add tilcdc_atomic_check() for mode_config_funcs
- Leave tilcdc_crtc_mode_fixup() connected to drm_crtc_helper_funcs

[1] https://lists.freedesktop.org/archives/dri-devel/2016-June/111258.html

Jyri Sarha (21):
drm/tilcdc: Fix tilcdc component master unloading drm/tilcdc: Make tilcdc_crtc_page_flip() public drm/tilcdc: Make tilcdc_crtc_page_flip() work if crtc is not yet on drm/tilcdc: Add dummy primary plane implementation drm/tilcdc: Initialize dummy primary plane from crtc init drm/tilcdc: Add tilcdc_crtc_mode_set_nofb()
drm/tilcdc: Add tilcdc_crtc_atomic_check()
drm/tilcdc: Add atomic mode config funcs
drm/tilcdc: Add drm_mode_config_reset() call to tilcdc_load() drm/tilcdc: Set DRIVER_ATOMIC and use atomic crtc helpers drm/tilcdc: Remove obsolete crtc helper functions drm/tilcdc: Remove tilcdc_verify_fb()
drm/tilcdc: panel: Set crtc panel info at init phase drm/tilcdc: panel: Add atomic modeset helpers to connector funcs drm/tilcdc: tfp410: Set crtc panel info at init phase drm/tilcdc: tfp410: Add atomic modeset helpers to connector funcs drm/tilcdc: Enable and disable interrupts in crtc start() and stop() drm/tilcdc: Use drm_atomic_helper_resume/suspend() drm/tilcdc: Get rid of legacy dpms mechanism
drm/tilcdc: Remove unnecessary pm_runtime_get() and *_put() calls drm/tilcdc: Change tilcdc_crtc_page_flip() to tilcdc_crtc_update_fb()

 drivers/gpu/drm/tilcdc/Makefile        |   1 +
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c   | 311 ++++++++++++++++-----------------
 drivers/gpu/drm/tilcdc/tilcdc_drv.c    | 210 +++++++++++-----------
 drivers/gpu/drm/tilcdc/tilcdc_drv.h    |  14 +-
 drivers/gpu/drm/tilcdc/tilcdc_panel.c  |  11 +-
 drivers/gpu/drm/tilcdc/tilcdc_plane.c  | 132 ++++++++++++++
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c |   8 +-
 7 files changed, 410 insertions(+), 277 deletions(-)
 create mode 100644 drivers/gpu/drm/tilcdc/tilcdc_plane.c
Signature · 6 lines
1.9.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel