Add buttons to build dashboard to customise/edit images
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 3 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | toaster: add build dashboard buttons to edit/create custom imagesbitbake/ bitbake/ bitbake/ +6 more | +344 | 1 reply | |
| 2/3 | toaster: add modal to select custom image for editingbitbake/ bitbake/ bitbake/ +6 more | +182 | 2 replies | |
| 3/3 | toaster-tests: tests for build dashboardbitbake/ bitbake/ | +251 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] Add buttons to build dashboard to customise/edit images
Add buttons to the build dashboard which enable a user to customise an image built during that build, or to create a custom image from an image built during that build.
To test:
1. Create a project.
2. Build an image like core-image-minimal.
3. When the build completes, go to its build dashboard. Click the button in the left navigation which creates a custom image from the built image.
4. Run a build like "core-image-minimal core-image-sato".
5. In the build dashboard again, click on the button to create a custom image from the images built during that build. You should see a dialog with radio buttons allowing you to choose which image to customise.
6. Create a custom image.
7. Run a build of that custom image.
8. When the build completes, view its build dashboard. It should have a button which links to the custom image edit page for the image.
9. Create a second custom image.
10. Run a build which builds both of your custom images.
11. When the build completes, view its build dashboard. It should have a button which, when clicked, gives a choice of the two custom images for editing.
Repeat the above with any combinations of the 4 images you've already built. Note that the UI tests cover the above combinations.
The following changes since commit 4bb6fb30b0d660eaeaf4af134b99b2feaf0b3db2:
toaster: fixes for customimage package not found (2016-04-08 09:38:50 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib elliot/toaster/build_history_ic_links_with_tests-9123
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/build_history_ic_links_with_tests-9123
Related bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=9123
Elliot Smith (3):
toaster: add build dashboard buttons to edit/create custom images
toaster: add modal to select custom image for editing
toaster-tests: tests for build dashboard
bitbake/lib/toaster/orm/models.py | 48 ++++ .../tests/browser/test_builddashboard_page.py | 251 +++++++++++++++++++++ .../lib/toaster/toastergui/static/js/layerBtn.js | 3 +- .../lib/toaster/toastergui/static/js/libtoaster.js | 2 + .../toastergui/static/js/newcustomimage_modal.js | 98 +++++++- .../toaster/toastergui/static/js/recipedetails.js | 3 +- bitbake/lib/toaster/toastergui/templates/base.html | 1 - .../toastergui/templates/basebuildpage.html | 213 +++++++++++------ .../templates/editcustomimage_modal.html | 71 ++++++ .../toastergui/templates/newcustomimage_modal.html | 28 ++- .../templatetags/objects_to_dictionaries_filter.py | 35 +++ bitbake/lib/toaster/toastergui/tests.py | 87 ------- bitbake/lib/toaster/toastergui/views.py | 33 ++- 13 files changed, 691 insertions(+), 182 deletions(-) create mode 100644 bitbake/lib/toaster/tests/browser/test_builddashboard_page.py create mode 100644 bitbake/lib/toaster/toastergui/templates/editcustomimage_modal.html create mode 100644 bitbake/lib/toaster/toastergui/templatetags/objects_to_dictionaries_filter.py
--
1.9.3
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.