RFC pskb_extract() helper function.
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest2 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | skbuff: Add pskb_extract() helper functioninclude/ net/ | +250 | 0 replies | |
| 2/2 | RDS: TCP: Call pskb_extract() helper functionnet/ | +3 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH RFC net-next 0/2] pskb_extract() helper function.
This patchset follows up on the discussion in
https://www.mail-archive.com/[email protected]/msg105090.html
For RDS-TCP, we have to deal with the full gamut of nonlinear sk_buffs, including all the frag_list variants. Also, the parent skb has to remain unchanged, while the clone is queued for Rx on the PF_RDS socket.
Patch 1 of this patchset adds a pskb_extract() function that does all this without the redundant memcpy's in pskb_expand_head() and __pskb_pull_tail().
A further optimization is also possible by inlining pskb_trim() itself into pskb_carve() and thus avoiding the needless copy of trailer frags/pages that will then get trimmed away. I am deferring that optimization for the next iteration, and would like to get feedback on this first pass, which by itself gives a noticeable perf boost.
Sowmini Varadhan (2):
Add pskb_extract() helper function
Call pskb_extract() helper function
include/linux/skbuff.h | 2 + net/core/skbuff.c | 248 ++++++++++++++++++++++++++++++++++++++++++++++++ net/rds/tcp_recv.c | 14 +-- 3 files changed, 253 insertions(+), 11 deletions(-)