Skip to content

macsec: a few fixes

Sabrina Dubroca netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest9 patches 4 repliesIn review
  2. v15 patches 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9macsec: add missing NULL check after kmallocdrivers/net/macsec.c+2 -23 replies
2/9macsec: take rtnl lock before for_each_netdevdrivers/net/macsec.c+2 -50 replies
3/9macsec: don't put a NULL rxsadrivers/net/macsec.c+2 -10 replies
4/9macsec: fix rx_sa refcounting with decrypt callbackdrivers/net/macsec.c+9 -70 replies
5/9macsec: add consistency check to netlink dumpsdrivers/net/macsec.c+11 -00 replies
6/9macsec: fix memory leaks around rx_handler (un)registrationdrivers/net/macsec.c+6 -20 replies
7/9macsec: fix SA leak if initialization failsdrivers/net/macsec.c+2 -00 replies
8/9macsec: add missing macsec prefix in uapidrivers/net/macsec.c include/uapi/linux/if_macsec.h+9 -70 replies
9/9macsec: fix netlink attribute validationdrivers/net/macsec.c+2 -20 replies

Reviews trailers per patch

All 9 patches have a Reviewed-by or Acked-by.

PatchHannes Frederic Sowa
1/9A-b
2/9A-b
3/9A-b
4/9A-b
5/9A-b
6/9A-b
7/9A-b
8/9A-b
9/9A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH net v2 0/9] macsec: a few fixes

Some small fixes for the macsec driver:
- possible NULL pointer dereferences
- netlink dumps fixes: RTNL locking, consistent dumps
- a reference counting bug
- wrong name for uapi constant
- a few memory leaks

Patches 1 to 5 are the same as in v1, patches 6 to 9 are new. Patch 6 fixes the memleak that Lance spotted in v1.

Sabrina Dubroca (9):
macsec: add missing NULL check after kmalloc
macsec: take rtnl lock before for_each_netdev
macsec: don't put a NULL rxsa
macsec: fix rx_sa refcounting with decrypt callback
macsec: add consistency check to netlink dumps
macsec: fix memory leaks around rx_handler (un)registration
macsec: fix SA leak if initialization fails
macsec: add missing macsec prefix in uapi
macsec: fix netlink attribute validation

 drivers/net/macsec.c           | 65 +++++++++++++++++++++++++++---------------
 include/uapi/linux/if_macsec.h |  4 +--
 2 files changed, 44 insertions(+), 25 deletions(-)
Signature · 1 line
2.8.0