Skip to content

Capture command-line builds which fail due to bad targets

Elliot Smith yocto-toaster 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2cooker: add BuildInit eventbitbake/lib/bb/cooker.py bitbake/lib/bb/event.py+11 -10 replies
2/2toasterui: use BuildInit to capture builds with bad targetsbitbake/lib/bb/ui/buildinfohelper.py bitbake/lib/bb/ui/toasterui.py+18 -180 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Capture command-line builds which fail due to bad targets

Toaster currently can't catch build failures which are due to bad targets (e.g. "bitbake ecky-thump"), as the bitbake run doesn't reach the BuildStarted event in these cases.

Add a new BuildInit event which fires as soon as buildTargets() or buildFile() is invoked, and make the build object at this point. When BuildStarted fires, collect layer information, build variables etc. as previously.

Backwards-compatibility is maintained for jethro by still making a build object on BuildStarted events. jethro builds which fail early will therefore not be captured by the new code, but existing functionality should not be broken either.

To test:

1. Start Toaster.
2. On the command-line, run a build with a bad target like "bitbake ecky-thump".
3. The build should register as a failure on the "all builds" page.

The following changes since commit fb8349b97c736d6633b2d79a4003dd86f760bdb1 (toaster-next):

toaster: bin/toaster Fix noweb command (2016-04-21 14:19:05 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib elliot/toaster/failed_builds-8440-v6
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/failed_builds-8440-v6

Elliot Smith (2):
cooker: add BuildInit event
toasterui: use BuildInit to capture builds with bad targets

 bitbake/lib/bb/cooker.py             |  6 ++++++
 bitbake/lib/bb/event.py              |  6 +++++-
 bitbake/lib/bb/ui/buildinfohelper.py | 17 ++++++++++-------
 bitbake/lib/bb/ui/toasterui.py       | 19 ++++++++-----------
 4 files changed, 29 insertions(+), 19 deletions(-)

--
1.9.3

---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.