Improve how to determine METADATA_REVISION
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest1 patch 0 repliesNew
- v11 patch 4 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | metadata_scm.bbclass: Do not assume ${COREBASE} is a Git repometa/ | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCHv2 0/1] Improve how to determine METADATA_REVISION
We noticed that METADATA_REVISION was always set to '<unknown>' in our builds. It turned out that this was because the code in metadata_scm.bbclass that sets it assumed that ${COREBASE} contains a repository. This may be true when working with Poky, but is not necessarily true for other setups. E.g., in our setup we clone Poky, OpenEmbedded and other repositories using the repo tool and then create symbolic links from the base directory to the parts that we want. Since ${COREBASE} is defined based on the path to the meta layer, it should be a better option to use ${COREBASE}/meta when looking for the SCM meta information.
Since this works as expected for Git but not SVN, I removed the option to call base_get_metadata_svn_revision() from base_detect_revision(). I doubt this should affect anyone (partly based on the comment in base_get_metadata_svn_revision()), but if this is not acceptable, it should be trivial to change the code so the meta directory is only used when looking for Git meta information. However, since it would require the introduction of two functions to wrap the Git functions, I refrained from this option until requested otherwise.
PATCHv2: Added note about the removed call to base_get_metadata_svn_revision() to the commit message.
//Peter
The following changes since commit f7b520878babbaa7527151f22c031ae160512753:
poky: Switch to post release name/version (2016-04-29 07:58:46 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib pkj/metadata_scm
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/metadata_scm
Peter Kjellerstedt (1):
metadata_scm.bbclass: Do not assume ${COREBASE} is a Git repo
meta/classes/metadata_scm.bbclass | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
Signature · 1 line
2.1.0