Skip to content

Runtime PM for Thunderbolt on Macs

Lukas Wunner linux-pci linux-pm 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest8 patches 15 repliesIn review
  2. v58 patches 18 repliesSuperseded
  3. v48 patches 8 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v37 patches4 repliesSuperseded
v213 patches48 repliesSuperseded

Changes in v6 from the cover letter

- Patch [1/8] ("PCI: Recognize Thunderbolt devices"):
Rename set_pcie_vendor_specific() (Bjorn Helgaas)

- Patch [3/8] ("PCI: pciehp: Reinstate runtime PM on Thunderbolt hotplug ports"): Modified version of reverted patch

- Patch [7/8] ("thunderbolt: Power down controller when idle"):
Add comment explaining use of pr_*() instead of dev_*(), drop unnecessary initialization (Bjorn Helgaas)

- Polish commit messages

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8PCI: Recognize Thunderbolt devicesdrivers/pci/pci.h drivers/pci/probe.c include/linux/pci.h+35 -05 replies
2/8PCI: Allow runtime PM on Thunderbolt portsdrivers/pci/pci.c+5 -13 replies
3/8PCI: pciehp: Reinstate runtime PM on Thunderbolt hotplug portsdrivers/pci/hotplug/pciehp_ctrl.c drivers/pci/pci.c+20 -74 replies
4/8Revert "PM / Runtime: Remove the exported function pm_children_suspended()"drivers/base/power/runtime.c include/linux/pm_runtime.h+8 -20 replies
5/8PM: Make requirements of dev_pm_domain_set() more precisedrivers/base/power/common.c+11 -40 replies
6/8PM / sleep: Define constant for direct_completeinclude/linux/pm.h+7 -00 replies
7/8thunderbolt: Power down controller when idledrivers/thunderbolt/Kconfig drivers/thunderbolt/Makefile drivers/thunderbolt/nhi.c +3 more+396 -30 replies
8/8thunderbolt: Runtime suspend NHI when idledrivers/thunderbolt/nhi.c drivers/thunderbolt/power.c drivers/thunderbolt/switch.c +1 more+33 -00 replies

Reviews trailers per patch

2 of 8 patches have a Reviewed-by or Acked-by.

PatchMika WesterbergBjorn HelgaasAndy Shevchenko
1/8
2/8R-b A-b
3/8
4/8
5/8
6/8A-b R-b
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH v6 0/8] Runtime PM for Thunderbolt on Macs

Power down Thunderbolt controllers on Macs when nothing is plugged in to save around 2W per controller and fix a power regression introduced in v3.17 that affects millions of machines (all Macs with Thunderbolt)

Changes since v5:

- Patch [1/8] ("PCI: Recognize Thunderbolt devices"):
Rename set_pcie_vendor_specific() (Bjorn Helgaas)

- Patch [3/8] ("PCI: pciehp: Reinstate runtime PM on Thunderbolt hotplug ports"): Modified version of reverted patch

- Patch [7/8] ("thunderbolt: Power down controller when idle"):
Add comment explaining use of pr_*() instead of dev_*(), drop unnecessary initialization (Bjorn Helgaas)

- Polish commit messages

Link to v5:
https://lkml.org/lkml/2017/1/15/180

Browse the patches on GitHub:
https://github.com/l1k/linux/commits/thunderbolt_runpm_v6

Thanks,

Lukas

Chen Yu (1):
PM / sleep: Define constant for direct_complete

Lukas Wunner (7):
PCI: Recognize Thunderbolt devices
PCI: Allow runtime PM on Thunderbolt ports
PCI: pciehp: Reinstate runtime PM on Thunderbolt hotplug ports Revert "PM / Runtime: Remove the exported function
pm_children_suspended()"
PM: Make requirements of dev_pm_domain_set() more precise
thunderbolt: Power down controller when idle
thunderbolt: Runtime suspend NHI when idle

 drivers/base/power/common.c       |  15 +-
 drivers/base/power/runtime.c      |   3 +-
 drivers/pci/hotplug/pciehp_ctrl.c |  13 +-
 drivers/pci/pci.c                 |  20 ++-
 drivers/pci/pci.h                 |   2 +
 drivers/pci/probe.c               |  32 ++++
 drivers/thunderbolt/Kconfig       |   3 +-
 drivers/thunderbolt/Makefile      |   4 +-
 drivers/thunderbolt/nhi.c         |   5 +
 drivers/thunderbolt/power.c       | 359 ++++++++++++++++++++++++++++++++++++++
 drivers/thunderbolt/power.h       |  37 ++++
 drivers/thunderbolt/switch.c      |   9 +
 drivers/thunderbolt/tb.c          |  13 ++
 drivers/thunderbolt/tb.h          |   2 +
 include/linux/pci.h               |   1 +
 include/linux/pm.h                |   7 +
 include/linux/pm_runtime.h        |   7 +
 17 files changed, 515 insertions(+), 17 deletions(-)
 create mode 100644 drivers/thunderbolt/power.c
 create mode 100644 drivers/thunderbolt/power.h
Signature · 1 line
2.11.0