Skip to content

ui: improve feedback if gl setup fails

Cole Robinson qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ui: egl: Replace fprintf with error_reportui/egl-helpers.c+14 -132 replies
2/3ui: spice: Exit if gl=on EGL init failsui/spice-core.c+4 -21 reply
3/3virtio-gpu: Warn if UI config will disable virglhw/display/virtio-gpu.c+5 -04 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchEric BlakeMarc-André Lureau
1/3R-b R-b
2/3R-b
3/3R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/3] ui: improve feedback if gl setup fails

patch 1 is just a cleanup, patch 2-3 improves feedback for invalid gl configs (which would have saved me an hour of head scratching)

Cole Robinson (3):
ui: egl: Replace fprintf with error_report
ui: spice: Exit if gl=on EGL init fails
virtio-gpu: Warn if UI config will disable virgl

 hw/display/virtio-gpu.c |  5 +++++
 ui/egl-helpers.c        | 27 ++++++++++++++-------------
 ui/spice-core.c         |  6 ++++--
 3 files changed, 23 insertions(+), 15 deletions(-)
Signature · 1 line
2.7.4