Skip to content

perf annotate: Support for AArch64

Chris Ryder linux-perf-users lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7perf annotate: Fix identification of ARM blt and bls instructionstools/perf/util/annotate.c+1 -10 replies
2/7perf annotate: Sort list of recognised instructionstools/perf/util/annotate.c+23 -50 replies
3/7pref annotate: Separate architecture specific annotation supporttools/perf/arch/arm/include/annotate_ins.h tools/perf/arch/x86/include/annotate_ins.h tools/perf/config/Makefile +2 more+136 -972 replies
4/7perf annotate: Separate out architecture specific parsingtools/perf/arch/arm/util/Build tools/perf/arch/arm/util/annotate_ins.c tools/perf/arch/x86/util/Build +5 more+57 -100 replies
5/7perf annotate: Architecture neutral handling of return instructiontools/perf/arch/arm/util/annotate_ins.c tools/perf/arch/x86/util/annotate_ins.c tools/perf/ui/browsers/annotate.c +2 more+27 -60 replies
6/7perf annotate: Make action message be architecture specifictools/perf/arch/arm/include/annotate_ins.h tools/perf/arch/x86/include/annotate_ins.h tools/perf/ui/browsers/annotate.c +1 more+6 -10 replies
7/7perf annotate: AArch64 supporttools/perf/arch/arm64/include/annotate_ins.h tools/perf/arch/arm64/util/Build tools/perf/arch/arm64/util/annotate_ins.c +1 more+64 -00 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchPawel Moll
1/7A-b
2/7A-b
3/7A-b
4/7A-b
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] perf annotate: Support for AArch64

Hi,

The linux perf tool has some basic support for annotating AArch32 branch instructions when displaying assembly. This patchset refactors the annotation support to have a cleaner separation between architectures, and then adds support for annotating AArch64 instructions.

Comments very welcome, thanks.
Chris.

Cc Peter Zijlstra <[email protected]>
Cc Ingo Molnar <[email protected]>
Cc Arnaldo Carvalho de Melo <[email protected]>
Cc Alexander Shishkin <[email protected]>
Cc Will Deacon <[email protected]>
Cc Mark Rutland <[email protected]>

Chris Ryder (7):
perf annotate: Fix identification of ARM blt and bls instructions perf annotate: Sort list of recognised instructions pref annotate: Separate architecture specific annotation support perf annotate: Separate out architecture specific parsing perf annotate: Architecture neutral handling of return instruction perf annotate: Make action message be architecture specific perf annotate: AArch64 support

 tools/perf/arch/arm/include/annotate_ins.h   |  27 +++++
 tools/perf/arch/arm/util/Build               |   2 +
 tools/perf/arch/arm/util/annotate_ins.c      |  22 ++++
 tools/perf/arch/arm64/include/annotate_ins.h |  40 +++++++
 tools/perf/arch/arm64/util/Build             |   2 +
 tools/perf/arch/arm64/util/annotate_ins.c    |  21 ++++
 tools/perf/arch/x86/include/annotate_ins.h   |  84 +++++++++++++++
 tools/perf/arch/x86/util/Build               |   1 +
 tools/perf/arch/x86/util/annotate_ins.c      |  17 +++
 tools/perf/config/Makefile                   |  12 +++
 tools/perf/ui/browsers/annotate.c            |  15 +--
 tools/perf/util/Build                        |   1 +
 tools/perf/util/annotate.c                   | 150 +++++++--------------------
 tools/perf/util/annotate_ins.c               |  21 ++++
 tools/perf/util/annotate_ins.h               |  17 +++
 15 files changed, 313 insertions(+), 119 deletions(-)
 create mode 100644 tools/perf/arch/arm/include/annotate_ins.h
 create mode 100644 tools/perf/arch/arm/util/annotate_ins.c
 create mode 100644 tools/perf/arch/arm64/include/annotate_ins.h
 create mode 100644 tools/perf/arch/arm64/util/annotate_ins.c
 create mode 100644 tools/perf/arch/x86/include/annotate_ins.h
 create mode 100644 tools/perf/arch/x86/util/annotate_ins.c
 create mode 100644 tools/perf/util/annotate_ins.c
 create mode 100644 tools/perf/util/annotate_ins.h
Signature · 1 line
2.1.4