Skip to content

RFC Deal with iio trigger names

Crestez Dan Leonard linux-iio lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest4 of 7 patches 6 repliesIn review

4 of 7 patches are in this archive. The cover letter announces 7.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
4/7iio: Add current_trigger_id alternativeDocumentation/ABI/testing/sysfs-bus-iio Documentation/DocBook/iio.tmpl drivers/iio/industrialio-trigger.c+98 -301 reply
5/7iio: generic_buffer: Use current_trigger_idtools/iio/generic_buffer.c+4 -40 replies
6/7iio: Refuse to register triggers with duplicate namesdrivers/iio/industrialio-trigger.c+21 -04 replies
7/7iio: Make trigger names uniquedrivers/iio/adc/max1027.c drivers/iio/common/st_sensors/st_sensors_trigger.c drivers/iio/light/gp2ap020a00f.c+5 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/7] Deal with iio trigger names

IIO documents that trigger names are unique but does not actually guarantee this. You can easily create a software trigger with a duplicate name if you enable CONFIG_IIO_HRTIMER_TRIGGER:

	mkdir /sys/kernel/config/iio/triggers/hrtimer/\
		`cat /sys/bus/iio/devices/trigger0/name`

You can also get in this situation if you connect two identical st_sensors.

My attempt to fix this is by adding a new 'current_trigger_id' ABI which is a numeric ID (X from triggerX) rather than a non-unique string. I tested that this works as expected when connecting two LIS3DH to the same system. This is in patches 4,5.

In theory the current_trigger ABI could be overloaded to looks for something matching "trigger[0-9]+" but this would be nastier. There would be a need to prevent registering triggers that match that expression in order to prevent stuff like:

mkdir /sys/kernel/config/iio/triggers/hrtimer/trigger1

Such an overload wouldn't work on read and make it impossible to unambigiously determine the currently selected trigger.

Patch 6 disallows registering duplicate trigger names. This makes drivers which currently do that break at probe time.

Patch 7 attempts to ensure that all drivers include indio_dev->id when calling iio_trigger_alloc. This obviously changes trigger names.

Either 4,5 or 6,7 fix this issue, but 4,5 causes fewer compat issues.

Patches 1,2,3 are just minor features in tools/generic_buffer. They supersede the v2 I posted earlier:

	https://www.spinics.net/lists/linux-iio/msg24867.html

Crestez Dan Leonard (7):
iio: generic_buffer: Cleanup when receiving signals
iio: generic_buffer: Add --device-num option
iio: generic_buffer: Add --trigger-num option
iio: Add current_trigger_id alternative
iio: generic_buffer: Use current_trigger_id
iio: Refuse to register triggers with duplicate names
iio: Make trigger names unique

 Documentation/ABI/testing/sysfs-bus-iio            |   9 +
 Documentation/DocBook/iio.tmpl                     |   4 +-
 drivers/iio/adc/max1027.c                          |   4 +-
 drivers/iio/common/st_sensors/st_sensors_trigger.c |   2 +-
 drivers/iio/industrialio-trigger.c                 | 136 ++++++++---
 drivers/iio/light/gp2ap020a00f.c                   |   4 +-
 tools/iio/generic_buffer.c                         | 269 ++++++++++++++-------
 7 files changed, 309 insertions(+), 119 deletions(-)
Signature · 1 line
2.5.5