Skip to content

Fix runtime pm ref leaks

Lukas Wunner dri-devel intel-gfx nouveau 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 of 9 patches 15 repliesIn review

3 of 9 patches are in this archive. The cover letter announces 9.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9drm/nouveau: Don't leak runtime pm ref on driver unloaddrivers/gpu/drm/nouveau/nouveau_drm.c+4 -15 replies
2/9drm/nouveau: Forbid runtime pm on driver unloaddrivers/gpu/drm/nouveau/nouveau_drm.c+1 -00 replies
9/9drm: Turn off crtc before tearing down its data structuredrivers/gpu/drm/drm_crtc.c+12 -110 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by.

PatchKarol Herbst
1/9T-b
2/9T-b
9/9T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/9] Fix runtime pm ref leaks

In preparation for runtime pm on muxed dual GPU laptops, I've fixed all runtime pm ref leaks I could find in nouveau, radeon and amdgpu.

To ease reviewing, I've pushed this series to GitHub:
https://github.com/l1k/linux/commits/drm_runpm_fixes_v1

@Alex Deucher: I do not have an AMD GPU so couldn't test this beyond verifying that it compiles. Please double-check the patches and test them internally at AMD. By the way, I've noticed that nouveau takes a runtime pm ref in ->preclose and releases it in ->postclose. This is missing in radeon and amdgpu. Please check if it is needed.

Thanks,

Lukas

Lukas Wunner (9):
drm/nouveau: Don't leak runtime pm ref on driver unload drm/nouveau: Forbid runtime pm on driver unload drm/radeon: Don't leak runtime pm ref on driver unload drm/radeon: Don't leak runtime pm ref on driver load drm/radeon: Forbid runtime pm on driver unload drm/amdgpu: Don't leak runtime pm ref on driver unload drm/amdgpu: Don't leak runtime pm ref on driver load drm/amdgpu: Forbid runtime pm on driver unload
drm: Turn off crtc before tearing down its data structure

 drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 12 +++++++++---
 drivers/gpu/drm/drm_crtc.c              | 13 ++++++++++++-
 drivers/gpu/drm/nouveau/nouveau_drm.c   |  6 +++++-
 drivers/gpu/drm/radeon/radeon_device.c  |  4 ++++
 drivers/gpu/drm/radeon/radeon_kms.c     |  5 ++++-
 5 files changed, 34 insertions(+), 6 deletions(-)
Signature · 6 lines
2.8.1

_______________________________________________
Nouveau mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/nouveau