Virtualization of the refs API
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest38 patches 10 repliesIn review
- v138 patches 28 repliesSuperseded
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/38 | resolve_gitlink_ref(): eliminate temporary variablerefs/ | +2 | 0 replies | |
| 2/38 | rename_ref_available(): add docstringrefs.c refs/ | +17 | 2 replies | |
| 3/38 | refs: rename struct ref_cache to files_ref_storerefs/ | +63 | 0 replies | |
| 4/38 | refs: add a backend method structurerefs.c refs.h refs/ +1 more | +34 | 1 reply | |
| 5/38 | refs: create a base class "ref_store" for files_ref_storerefs.c refs/ refs/ | +270 | 4 replies | |
| 6/38 | add_packed_ref(): add a files_ref_store argumentrefs/ | +5 | 0 replies | |
| 7/38 | get_packed_ref(): add a files_ref_store argumentrefs/ | +9 | 0 replies | |
| 8/38 | resolve_missing_loose_ref(): add a files_ref_store argumentrefs/ | +6 | 0 replies | |
| 9/38 | {lock,commit,rollback}_packed_refs(): add files_ref_store argumentsrefs/ | +16 | 0 replies | |
| 10/38 | refs: add a transaction_commit() methodrefs.c refs/ refs/ | +20 | 0 replies | |
| 11/38 | refs: reorder definitionsrefs/ | +83 | 0 replies | |
| 12/38 | resolve_packed_ref(): rename function from resolve_missing_loose_ref()refs/ | +5 | 0 replies | |
| 13/38 | resolve_gitlink_packed_ref(): remove functionrefs/ | +5 | 0 replies | |
| 14/38 | read_raw_ref(): take a (struct ref_store *) argumentrefs.c refs/ refs/ | +22 | 0 replies | |
| 15/38 | resolve_ref_recursively(): new functionrefs.c | +11 | 0 replies | |
| 16/38 | resolve_gitlink_ref(): implement using resolve_ref_recursively()refs.c refs/ | +24 | 0 replies | |
| 17/38 | resolve_gitlink_ref(): avoid memory allocation in many casesrefs.c | +13 | 0 replies | |
| 18/38 | resolve_gitlink_ref(): rename path parameter to submodulerefs.c refs.h | +12 | 0 replies | |
| 19/38 | refs: make read_raw_ref() virtualrefs.c refs/ refs/ | +29 | 0 replies | |
| 20/38 | refs: make verify_refname_available() virtualrefs.c refs/ refs/ | +25 | 0 replies | |
| 21/38 | refs: make pack_refs() virtualrefs.c refs/ refs/ | +15 | 0 replies | |
| 22/38 | refs: make create_symref() virtualrefs.c refs/ refs/ | +20 | 0 replies | |
| 23/38 | refs: make peel_ref() virtualrefs.c refs/ refs/ | +14 | 0 replies | |
| 24/38 | repack_without_refs(): add a files_ref_store argumentrefs/ | +7 | 0 replies | |
| 25/38 | lock_raw_ref(): add a files_ref_store argumentrefs/ | +8 | 0 replies | |
| 26/38 | commit_ref_update(): add a files_ref_store argumentrefs/ | +8 | 0 replies | |
| 27/38 | lock_ref_for_update(): add a files_ref_store argumentrefs/ | +6 | 0 replies | |
| 28/38 | lock_ref_sha1_basic(): add a files_ref_store argumentrefs/ | +15 | 0 replies | |
| 29/38 | split_symref_update(): add a files_ref_store argumentrefs/ | +4 | 0 replies | |
| 30/38 | files_ref_iterator_begin(): take a ref_store argumentrefs.c refs/ refs/ | +7 | 0 replies | |
| 31/38 | refs: add method iterator_beginrefs.c refs/ refs/ | +15 | 0 replies | |
| 32/38 | refs: add methods for reflogrefs.c refs/ refs/ | +150 | 0 replies | |
| 33/38 | refs: add method for initial ref transaction commitrefs.c refs/ refs/ | +14 | 0 replies | |
| 34/38 | refs: make delete_refs() virtualrefs.c refs/ refs/ | +14 | 0 replies | |
| 35/38 | refs: add methods to init refs dbbuiltin/ refs.c refs.h +2 more | +42 | 0 replies | |
| 36/38 | refs: add method to rename refsrefs.c refs/ refs/ | +17 | 0 replies | |
| 37/38 | refs: make lock genericrefs/ refs/ | +14 | 0 replies | |
| 38/38 | refs: implement iteration over only per-worktree refsrefs/ refs/ | +13 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 00/38] Virtualization of the refs API
This is v2 of the patch series to virtualize the references API (though earlier patch series similar in spirit were submitted by Ronnie Sahlberg and David Turner). Thanks to Junio, Eric, and Ramsay for their comments about v1 [1].
Nobody pointed out any fundamental problems with v1, but this version includes the following improvements:
* In "rename_ref_available(): add docstring":
* Improve docstring as suggested by Junio.
* In "refs: create a base class "ref_store" for files_ref_store":
* Let main_ref_store and submodule_ref_stores be initialized implicitly rather than initializing them explicitly to NULL.
* Add docstrings for those two variables.
* Eliminate a temporary variable in files_downcast().
* In "resolve_gitlink_ref(): avoid memory allocation in many cases":
* Instead of keeping track of orig_len, after stripping off any trailing slashes check whether path[len - 1] is NUL.
* In "refs: add methods for reflog":
* Don't export files_reflog_iterator_begin() (suggested by Ramsay).
In addition, given that v1 was pretty old, I have rebased the patch series against the current upstream master. (The rebase was unproblematic.)
This patch series is also available from my GitHub fork [2] as branch "ref-store".
Michael
[1] http://public-inbox.org/git/[email protected]/t/
[2] https://github.com/mhagger/git
David Turner (8):
rename_ref_available(): add docstring
refs: add methods for reflog
refs: add method for initial ref transaction commit
refs: make delete_refs() virtual
refs: add methods to init refs db
refs: add method to rename refs
refs: make lock generic
refs: implement iteration over only per-worktree refs
Michael Haggerty (28):
resolve_gitlink_ref(): eliminate temporary variable
refs: rename struct ref_cache to files_ref_store
refs: create a base class "ref_store" for files_ref_store add_packed_ref(): add a files_ref_store argument get_packed_ref(): add a files_ref_store argument resolve_missing_loose_ref(): add a files_ref_store argument {lock,commit,rollback}_packed_refs(): add files_ref_store arguments
refs: reorder definitions
resolve_packed_ref(): rename function from resolve_missing_loose_ref() resolve_gitlink_packed_ref(): remove function read_raw_ref(): take a (struct ref_store *) argument resolve_ref_recursively(): new function resolve_gitlink_ref(): implement using resolve_ref_recursively() resolve_gitlink_ref(): avoid memory allocation in many cases resolve_gitlink_ref(): rename path parameter to submodule
refs: make read_raw_ref() virtual
refs: make verify_refname_available() virtual
refs: make pack_refs() virtual
refs: make create_symref() virtual
refs: make peel_ref() virtual
repack_without_refs(): add a files_ref_store argument lock_raw_ref(): add a files_ref_store argument commit_ref_update(): add a files_ref_store argument lock_ref_for_update(): add a files_ref_store argument lock_ref_sha1_basic(): add a files_ref_store argument split_symref_update(): add a files_ref_store argument files_ref_iterator_begin(): take a ref_store argument
refs: add method iterator_begin
Ronnie Sahlberg (2):
refs: add a backend method structure
refs: add a transaction_commit() method
builtin/init-db.c | 21 +- refs.c | 309 +++++++++++++++++++++++++++- refs.h | 13 +- refs/files-backend.c | 566 +++++++++++++++++++++++++++------------------------ refs/refs-internal.h | 220 +++++++++++++++++--- 5 files changed, 812 insertions(+), 317 deletions(-)
Signature · 1 line
2.9.3