Skip to content

copy_mount_options improvements

Andy Lutomirski linux-fsdevel stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 13 repliesIn review
  2. v12 patches 0 repliesSuperseded

Changes in v2 from the cover letter

- Fix some blatant memory corruption :(

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2fs: Improve and simplify copy_mount_optionsfs/namespace.c+12 -4413 replies
2/2fs: Disallow mount options strings longer than PAGE_SIZE - 1fs/namespace.c+7 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] copy_mount_options improvements

Patch 1 fixes what is arguably a bug. I suspect it could cause crashes or very large latency under unusual circumstanes. Since it also deletes a bunch of code, I think it's a nice fix.

Patch 2 is an ABI change/fix. Any user code that would be affected is currently buggy (i.e. results in incorrect option parsing), so I suspect it can be applied safely.

Changes from v1:
- Fix some blatant memory corruption :(

Andy Lutomirski (2):
fs: Improve and simplify copy_mount_options
fs: Disallow mount options strings longer than PAGE_SIZE - 1

 fs/namespace.c | 62 ++++++++++++++--------------------------------------------
 1 file changed, 15 insertions(+), 47 deletions(-)
Signature · 1 line
2.7.4