Skip to content

drm/tilcdc Fixes and cleanups

Jyri Sarha dri-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest8 patches 1 replyIn review
  2. v47 patches 0 repliesSuperseded
  3. v37 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v26 patches5 repliesSuperseded
v15 patches4 repliesSuperseded

Changes in v5 from the cover letter

- Split
"drm/tilcdc: Move LCDC_SYNC_LOST handling inside if (ver == 2) statement" out of
"drm/tilcdc: Write to LCDC_END_OF_INT_IND_REG at the end of IRQ"

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8drm/tilcdc: Restore old dpms state in pm_resume()drivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+12 -00 replies
2/8drm/tilcdc: Move LCDC_SYNC_LOST handling inside if (ver == 2) statementdrivers/gpu/drm/tilcdc/tilcdc_crtc.c+10 -110 replies
3/8drm/tilcdc: Write to LCDC_END_OF_INT_IND_REG at the end of IRQ functiondrivers/gpu/drm/tilcdc/tilcdc_crtc.c+10 -50 replies
4/8drm/tilcdc: Move waiting of LCDC_FRAME_DONE IRQ into stop()drivers/gpu/drm/tilcdc/tilcdc_crtc.c+16 -150 replies
5/8drm/tilcdc: Increase time out for waiting frame done interruptdrivers/gpu/drm/tilcdc/tilcdc_crtc.c+1 -10 replies
6/8drm/tilcdc: Call drm_crtc_vblank_on() and *_off() in start() and stop()drivers/gpu/drm/tilcdc/tilcdc_crtc.c+4 -00 replies
7/8drm/tilcdc: Refer to panel.txt and tfp410.txt bindings in tilcdc.txtDocumentation/devicetree/bindings/display/tilcdc/tilcdc.txt+4 -00 replies
8/8drm/tilcdc: Avoid error print by of_graph_get_next_endpoint()drivers/gpu/drm/tilcdc/tilcdc_external.c+11 -20 replies

Reviews trailers per patch

None of the 8 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTomi Valkeinen
SeriesR-b
1/8
2/8
3/8
4/8
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/8] drm/tilcdc Fixes and cleanups

Some fixes and cleanups that should get merged to tilcdc even if my atomic changes are still a work in progress.

Yet one more round, sorry for spamming.

Changes since v4:
- Split
"drm/tilcdc: Move LCDC_SYNC_LOST handling inside if (ver == 2) statement" out of
"drm/tilcdc: Write to LCDC_END_OF_INT_IND_REG at the end of IRQ"

Changes since v3:
- "drm/tilcdc: Write to LCDC_END_OF_INT_IND_REG at the end of IRQ"
- Do not bail out in the middle of irq routine, use full

    "if (rev == 2)"-statement in stead

Changes since v2:
- "drm/tilcdc: Restore old dpms state in pm_resume()"
- Improve description
- "drm/tilcdc: Write to LCDC_END_OF_INT_IND_REG at the end of IRQ
- Handle LCDC_FIFO_UNDERFLOW also for v1 silicon
- "drm/tilcdc: Move waiting of LCDC_FRAME_DONE IRQ into stop()"
- Improve description
- Add "drm/tilcdc: Increase time out for waiting frame done interrupt"

Changes since first version:
- "drm/tilcdc: Restore old dpms state in pm_resume()"
- Fix typos from description and subject
- Add "drm/tilcdc: Call drm_crtc_vblank_on() and *_off() in start() and stop()"

Jyri Sarha (8):
drm/tilcdc: Restore old dpms state in pm_resume() drm/tilcdc: Move LCDC_SYNC_LOST handling inside if (ver == 2)
statement
drm/tilcdc: Write to LCDC_END_OF_INT_IND_REG at the end of IRQ
function
drm/tilcdc: Move waiting of LCDC_FRAME_DONE IRQ into stop() drm/tilcdc: Increase time out for waiting frame done interrupt drm/tilcdc: Call drm_crtc_vblank_on() and *_off() in start() and

    stop()

drm/tilcdc: Refer to panel.txt and tfp410.txt bindings in tilcdc.txt drm/tilcdc: Avoid error print by of_graph_get_next_endpoint()

 .../devicetree/bindings/display/tilcdc/tilcdc.txt  |  4 ++
 drivers/gpu/drm/tilcdc/tilcdc_crtc.c               | 78 +++++++++++++---------
 drivers/gpu/drm/tilcdc/tilcdc_drv.c                |  3 +
 drivers/gpu/drm/tilcdc/tilcdc_drv.h                |  2 +
 drivers/gpu/drm/tilcdc/tilcdc_external.c           | 13 +++-
 5 files changed, 67 insertions(+), 33 deletions(-)
Signature · 6 lines
1.9.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel