Skip to content

rtc-cmos: Workaround unwanted interrupt generation

Pratyush Anand linux-rtc lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 8 repliesIn review
  2. v22 patches 0 repliesSuperseded
  3. v1 RFC2 patches 7 repliesSuperseded

Changes in v3 from the cover letter

- Improved commit log further

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2rtc/hpet: Factorize hpet_rtc_timer_init()arch/x86/include/asm/hpet.h arch/x86/kernel/hpet.c+37 -60 replies
2/2rtc/rtc-cmos: Initialize software counters before irq is registereddrivers/rtc/rtc-cmos.c+12 -18 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH V3 0/2] rtc-cmos: Workaround unwanted interrupt generation

We have observed on few machines with rtc-cmos devices that it generates an interrupt before the hpet_rtc_timer_init() call is finished. This leads to hpet_rtc_interrupt() being called before it is fully initialized.

Therefore the while-loop of hpet_cnt_ahead() in hpet_rtc_timer_reinit() never completes. This leads to "NMI watchdog: Watchdog detected hard LOCKUP on cpu 0".

This patch set initializes hpet_default_delta and hpet_t1_cmp before interrupt can be raised.

Changes since V2:
- Improved commit log further
Changes since RFC:
- Commit log of patches has been improved.

Pratyush Anand (2):
rtc/hpet: Factorize hpet_rtc_timer_init()
rtc/rtc-cmos: Initialize software counters before irq is registered

 arch/x86/include/asm/hpet.h |  2 ++
 arch/x86/kernel/hpet.c      | 41 +++++++++++++++++++++++++++++++++++------
 drivers/rtc/rtc-cmos.c      | 13 ++++++++++++-
 3 files changed, 49 insertions(+), 7 deletions(-)
Signature · 11 lines
2.5.5

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
For more options, visit https://groups.google.com/d/optout.