Skip to content

common library for Chelsio drivers.

Varun Prakash linux-scsi netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 1 replyIn review
  2. v26 patches 3 repliesSuperseded
  3. v16 patches 10 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6libcxgb: add library module for Chelsio driversdrivers/net/ethernet/chelsio/Kconfig drivers/net/ethernet/chelsio/Makefile drivers/net/ethernet/chelsio/cxgb4/Makefile +6 more+81 -260 replies
2/6cxgb3i,cxgb4i,libcxgbi: remove iSCSI DDP supportdrivers/scsi/cxgbi/cxgb3i/cxgb3i.c drivers/scsi/cxgbi/cxgb4i/cxgb4i.c drivers/scsi/cxgbi/libcxgbi.c +1 more+0 -10090 replies
3/6cxgb4i,libcxgbi: add iSCSI DDP supportdrivers/scsi/cxgbi/Makefile drivers/scsi/cxgbi/cxgb3i/Kbuild drivers/scsi/cxgbi/cxgb3i/Kconfig +5 more+507 -20 replies
4/6cxgb3i: add iSCSI DDP supportdrivers/scsi/cxgbi/cxgb3i/cxgb3i.c+118 -10 replies
5/6libcxgb: export ppm release and tagmask set apidrivers/net/ethernet/chelsio/libcxgb/libcxgb_ppm.c drivers/scsi/cxgbi/cxgb3i/cxgb3i.c drivers/scsi/cxgbi/libcxgbi.c +1 more+6 -00 replies
6/6cxgb3i,cxgb4i: fix symbol not declared sparse warningdrivers/scsi/cxgbi/cxgb3i/cxgb3i.c drivers/scsi/cxgbi/cxgb4i/cxgb4i.c+3 -30 replies

Reviews trailers per patch

4 of 6 patches have a Reviewed-by or Acked-by.

PatchSteve Wise
1/6R-b
2/6
3/6
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [net-next v3 0/6] common library for Chelsio drivers.

Hi,

This patch series adds common library module(libcxgb.ko) for Chelsio drivers to remove duplicate code.

This series moves common iSCSI DDP Page Pod manager code from cxgb4.ko to libcxgb.ko, earlier this code was used by only cxgbit.ko now it is used by three Chelsio iSCSI drivers cxgb3i, cxgb4i, cxgbit.

In future this module will have common connection management and hardware specific code that can be shared by multiple Chelsio drivers(cxgb4, csiostor, iw_cxgb4, cxgb4i, cxgbit).

Please review.

Thanks

-v3
- removed unused module init and exit functions.

-v2
- updated CONFIG_CHELSIO_LIB to an invisible option
- changed libcxgb.ko module license from GPL to Dual BSD/GPL

Varun Prakash (6):
libcxgb: add library module for Chelsio drivers cxgb3i,cxgb4i,libcxgbi: remove iSCSI DDP support cxgb4i,libcxgbi: add iSCSI DDP support
cxgb3i: add iSCSI DDP support
libcxgb: export ppm release and tagmask set api cxgb3i,cxgb4i: fix symbol not declared sparse warning

 drivers/net/ethernet/chelsio/Kconfig               |  16 +-
 drivers/net/ethernet/chelsio/Makefile              |   1 +
 drivers/net/ethernet/chelsio/cxgb4/Makefile        |   1 -
 drivers/net/ethernet/chelsio/libcxgb/Makefile      |   3 +
 .../{cxgb4/cxgb4_ppm.c => libcxgb/libcxgb_ppm.c}   |  45 +-
 .../{cxgb4/cxgb4_ppm.h => libcxgb/libcxgb_ppm.h}   |  38 +-
 drivers/scsi/cxgbi/Makefile                        |   2 +
 drivers/scsi/cxgbi/cxgb3i/Kbuild                   |   1 +
 drivers/scsi/cxgbi/cxgb3i/Kconfig                  |   1 +
 drivers/scsi/cxgbi/cxgb3i/cxgb3i.c                 | 164 +++--
 drivers/scsi/cxgbi/cxgb4i/Kbuild                   |   1 +
 drivers/scsi/cxgbi/cxgb4i/Kconfig                  |   1 +
 drivers/scsi/cxgbi/cxgb4i/cxgb4i.c                 | 203 +++---
 drivers/scsi/cxgbi/libcxgbi.c                      | 734 +++++++--------------
 drivers/scsi/cxgbi/libcxgbi.h                      | 188 +-----
 drivers/target/iscsi/cxgbit/Kconfig                |   2 +-
 drivers/target/iscsi/cxgbit/Makefile               |   1 +
 drivers/target/iscsi/cxgbit/cxgbit.h               |   2 +-
 drivers/target/iscsi/cxgbit/cxgbit_main.c          |   2 +
 19 files changed, 540 insertions(+), 866 deletions(-)
 create mode 100644 drivers/net/ethernet/chelsio/libcxgb/Makefile
 rename drivers/net/ethernet/chelsio/{cxgb4/cxgb4_ppm.c => libcxgb/libcxgb_ppm.c} (86%)
 rename drivers/net/ethernet/chelsio/{cxgb4/cxgb4_ppm.h => libcxgb/libcxgb_ppm.h} (84%)
Signature · 1 line
2.0.2