Skip to content

iio: humidity: hdc100x: update driver locking

Alison Schofield linux-iio lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2iio: humidity: hdc100x: move lock on config updates to single functiondrivers/iio/humidity/hdc100x.c+6 -101 reply
2/2iio: humidity: hdc100x: remove lock on heater configuration readdrivers/iio/humidity/hdc100x.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] iio: humidity: hdc100x: update driver locking

This patchset intends to tidy up the driver locking.

The global data lock needs to to protect writes to the configuration register and single channel reads which can be of temp or humidity.

First patch moves the config register locking to the config update function. This continues to protect updates to heater and integration times. It puts the lock in one place, right where it needs to occur.

Second patch removes the lock on configuration reads of data stored in global data. While the write lock prevents two simultaneous writes (ie. Heater and int_time) to the register, which could return false success status, the read doesn't have the same issue. You get the status at the moment, at it's guaranteed for that moment only. This also aligns with drivers non-locking of other reads of global data configuration status - ie integration time.

I believe these changes stand alone as good cleanups to the locking. Alas, my ulterior motive is to prep it so that I can cleanly apply the locks for triggered buffer mode.

Alison Schofield (2):
iio: humidity: hdc100x: move lock on config updates to single function
iio: humidity: hdc100x: remove lock on heater configuration read

 drivers/iio/humidity/hdc100x.c | 20 ++++++++------------
 1 file changed, 8 insertions(+), 12 deletions(-)
Signature · 1 line
2.1.4