iio: complete the setup of buffer timestamps
Status from this message: Applied to the fixes-togreg-post-rc1 branch of iio.git
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | iio: accel: bma220_spi: set up buffer timestamps for non-zero valuesdrivers/ | +1 | 2 replies | |
| 2/3 | iio: humidity: am2315: set up buffer timestamps for non-zero valuesdrivers/ | +1 | 2 replies | |
| 3/3 | iio: proximity: as3935: set up buffer timestamps for non-zero valuesdrivers/ | +1 | 1 reply |
Reviews trailers per patch
2 of 3 patches have a Reviewed-by or Acked-by.
| Patch | Tiberiu Breana |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] iio: complete the setup of buffer timestamps
These drivers are using iio_poll_func->timestamp in their triggered buffer handler as the timestamp pushed to buffer. Problem is that it was not set up at probe time via iio_triggered_buffer_setup(), so timestamp is always 0.
Buffer space has been allocated for the timestamp, so it seems to be wanted.
These patches make the fix io_triggered_buffer_setup() during probe by passing the iio_pollfunc_store_time parameter.
Alternative change would be to use iio_get_time_ns() directly in the push_to_buffers call in the handler. We can do this if you are not one of those "devices (who) need a timestamp grabbed as soon as possible after the trigger" (from iio_poll_func definition)
Either way you are using iio_get_tme_ns(), it's just a question of when. Let me know if you'd rather go the slower way.
Alison Schofield (3):
iio: accel: bma220_spi: set up buffer timestamps for non-zero values
iio: humidity: am2315: set up buffer timestamps for non-zero values
iio: proximity: as3935: set up buffer timestamps for non-zero values
drivers/iio/accel/bma220_spi.c | 2 +- drivers/iio/humidity/am2315.c | 2 +- drivers/iio/proximity/as3935.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
Signature · 1 line
2.1.4