Skip to content

Btrfs: free space tree and sanity test fixes

Omar Sandoval fstests linux-btrfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 24 repliesIn review
  2. v13 patches 15 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6Btrfs: fix free space tree bitmaps on big-endian systemsfs/btrfs/extent_io.c fs/btrfs/extent_io.h fs/btrfs/free-space-tree.c+76 -271 reply
2/6Btrfs: fix mount -o clear_cache,space_cache=v2fs/btrfs/disk-io.c+12 -121 reply
3/6Btrfs: catch invalid free space treesfs/btrfs/ctree.h fs/btrfs/disk-io.c fs/btrfs/free-space-tree.c +1 more+22 -27 replies
4/6Btrfs: fix extent buffer bitmap tests on big-endian systemsfs/btrfs/tests/extent-io-tests.c+51 -360 replies
5/6Btrfs: expand free space tree sanity tests to catch endianness bugfs/btrfs/tests/free-space-tree-tests.c+96 -680 replies
6/6Btrfs: use less memory for delalloc sanity testsfs/btrfs/tests/extent-io-tests.c+4 -45 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by.

PatchAnatoly PugachevFeifei XuHolger HoffstätteChandan Rajendra
SeriesT-b
1/6T-b
2/6T-b
3/6T-b
4/6T-b T-b
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/6] Btrfs: free space tree and sanity test fixes

From: Omar Sandoval <[email protected]>

This is v2 of my earlier series "Btrfs: fix free space tree bitmaps+tests on big-endian systems" [1]. Patches 1, 4, and 5 are the same as patches 1, 2, and 3 from the original series. I've added patch 2 to fix another bug I noticed (an xfstest went out earlier). Patch 3 is the result of the earlier discussion here [2]. Finally, patch 6 was necessary to get the sanity tests to run on my MIPS emulator.

This series applies to v4.8-rc7. The sanity tests pass on both x86-64 and MIPS, and there are no xfstests regressions. Chandan and Anatoly, could you test these out as well?

I'm working on the btrfs-progs follow up, but these patches are safe without that -- the new FREE_SPACE_TREE_VALID bit will stop all versions of btrfs-progs from mounting read-write.

Thanks!

1: http://marc.info/?l=linux-btrfs&m=146853909905570&w=2
2: http://marc.info/?l=linux-btrfs&m=147448992301110&w=2

Cc Chandan Rajendra <[email protected]>
Cc Anatoly Pugachev <[email protected]>

Omar Sandoval (6):
Btrfs: fix free space tree bitmaps on big-endian systems
Btrfs: fix mount -o clear_cache,space_cache=v2
Btrfs: catch invalid free space trees
Btrfs: fix extent buffer bitmap tests on big-endian systems
Btrfs: expand free space tree sanity tests to catch endianness bug
Btrfs: use less memory for delalloc sanity tests

 fs/btrfs/ctree.h                       |   3 +-
 fs/btrfs/disk-io.c                     |  33 ++++---
 fs/btrfs/extent_io.c                   |  64 +++++++++----
 fs/btrfs/extent_io.h                   |  22 +++++
 fs/btrfs/free-space-tree.c             |  19 ++--
 fs/btrfs/tests/extent-io-tests.c       |  95 +++++++++++--------
 fs/btrfs/tests/free-space-tree-tests.c | 164 +++++++++++++++++++--------------
 include/uapi/linux/btrfs.h             |  10 +-
 8 files changed, 261 insertions(+), 149 deletions(-)
Signature · 1 line
2.10.0