Skip to content

Prevent task dependency calculation going into an infinite loop

Elliot Smith yocto-toaster 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2toaster-tests: add test for showing self-dependent taskbitbake/lib/toaster/tests/browser/test_task_page.py+76 -00 replies
2/2toaster: prevent infinite loop when finding task dependenciesbitbake/lib/toaster/toastergui/views.py+10 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Prevent task dependency calculation going into an infinite loop

Where a task is "covered" by itself, Toaster is unable to display the task, as the code causes a non-terminating loop (see the commit logs for an explanation).

Add a condition to prevent this, and a test to make sure we don't reintroduce it later.

Related bug:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=9952

The following changes since commit 1826de5234aadb9aa51c83f86471cdd7e88b48cf (toaster-next):

toaster: loadconf Partially add back some of the layerSource parsing (2016-07-21 11:23:00 +0100)

are available in the git repository at:

git://git.yoctoproject.org/poky-contrib elliot/toaster/9952-covered_tasks_no_show
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=elliot/toaster/9952-covered_tasks_no_show

Elliot Smith (2):
toaster-tests: add test for showing self-dependent task
toaster: prevent infinite loop when finding task dependencies

 .../lib/toaster/tests/browser/test_task_page.py    | 76 ++++++++++++++++++++++
 bitbake/lib/toaster/toastergui/views.py            | 10 +++
 2 files changed, 86 insertions(+)
 create mode 100644 bitbake/lib/toaster/tests/browser/test_task_page.py

--
2.7.4