drm/tilcdc: Address LCDC rev 2 color errata + other fixes
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest8 patches 3 repliesIn review
- v38 patches 7 repliesSuperseded
- v27 patches 4 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 2 replies | Superseded |
Changes in v4 from the cover letter
- "drm/tilcdc: Write DMA base and ceiling address with single instruction"
- Adjust comments, no functional changes
- "drm/tilcdc: Add blue-and-red-crossed devicetree property"
- Remove "default" from recognized property values
- Clean up commit description
- "ARM: dts: am335x-boneblack: Add blue-and-red-wiring -property to LCDC node"
- Minor comment adjustmen
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | drm/tilcdc: Remove drm_helper_disable_unused_functions() calldrivers/ | +0 | 0 replies | |
| 2/8 | drm/tilcdc: Write DMA base and ceiling address with single instructiondrivers/ drivers/ | +22 | 0 replies | |
| 3/8 | drm/tilcdc: Add blue-and-red-crossed devicetree propertyDocumentation/ drivers/ drivers/ +1 more | +70 | 1 reply | |
| 4/8 | drm/tilcdc: Choose console BPP that supports RGBdrivers/ drivers/ drivers/ +3 more | +9 | 0 replies | |
| 5/8 | ARM: dts: am335x-boneblack: Add blue-and-red-wiring -property to LCDC nodearch/ | +11 | 2 replies | |
| 6/8 | ARM: dts: am335x-evm: Add blue-and-red-wiring -property to lcdc nodearch/ | +2 | 0 replies | |
| 7/8 | ARM: dts: am335x-evmsk: Whitespace cleanup of lcdc related nodesarch/ | +20 | 0 replies | |
| 8/8 | ARM: dts: am335x-evmsk: Add blue-and-red-wiring -property to lcdc nodearch/ | +2 | 0 replies |
Reviews trailers per patch
1 of 8 patches has a Reviewed-by or Acked-by.
| Patch | Rob Herring |
|---|---|
| 1/8 | |
| 2/8 | |
| 3/8 | A-b |
| 4/8 | |
| 5/8 | |
| 6/8 | |
| 7/8 | |
| 8/8 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/8] drm/tilcdc: Address LCDC rev 2 color errata + other fixes
Changes since v3:
- "drm/tilcdc: Write DMA base and ceiling address with single instruction"
- Adjust comments, no functional changes
- "drm/tilcdc: Add blue-and-red-crossed devicetree property"
- Remove "default" from recognized property values
- Clean up commit description
- "ARM: dts: am335x-boneblack: Add blue-and-red-wiring -property to LCDC node"
- Minor comment adjustmen
Changes since v2:
- Fiddle with color wiring propety once more, now it follows this Tomi's comment:
- No property set: driver advertises RG16 and RG24. This is wrong, but that's what the current status is, right?
- Property set to "default" or "straight" or whatever: driver says RG16 and BG24
- Property set to "crossed": driver says BG16 and RG24
- Add v2 version of "drm/tilcdc: Write DMA base and ceiling address with..."
- The first version was sent individually, this second version has
__iowmb(); and __cpu_to_le64(); added to tilcdc_write64()
Changes since v1:
- Change the blue-and-red-wiring property to boolean blue-and-red-crossed
- This breaks to little backward compatibility the earlier series had, but makes the binding more straight forward
- This changes requires changes to am335x-evm and am335x-evmsk dts-files
- The old beaglebone-black dts files remain compatible, but the patch suggests in commenst on how to support 24-bit RGB mode with BBB
The first patch ("drm/tilcdc: Remove drm_helper_disable_unused_functions() call") is completely independent fix.
The red and blue components are reversed between 24 and 16 bit modes on am335x LCDC output pins. To get 24 RGB format the wires red and blue wires has to be crossed and this in turn causes 16 colors output to be in BGR format. With straight wiring the 16 color is RGB and 24 bit is BGR. These patches try to deal with the issue in reasonable manner.
For more details see section 3.1.1 in AM335x Silicon Errata:
http://www.ti.com/general/docs/lit/getliterature.tsp?baseLiteratureNumber=sprz360
Jyri Sarha (8):
drm/tilcdc: Remove drm_helper_disable_unused_functions() call drm/tilcdc: Write DMA base and ceiling address with single instruction drm/tilcdc: Add blue-and-red-crossed devicetree property drm/tilcdc: Choose console BPP that supports RGB
ARM: dts: am335x-boneblack: Add blue-and-red-wiring -property to LCDC
node
ARM: dts: am335x-evm: Add blue-and-red-wiring -property to lcdc node
ARM: dts: am335x-evmsk: Whitespace cleanup of lcdc related nodes
ARM: dts: am335x-evmsk: Add blue-and-red-wiring -property to lcdc node
.../devicetree/bindings/display/tilcdc/tilcdc.txt | 22 +++++++++ arch/arm/boot/dts/am335x-boneblack.dts | 11 +++++ arch/arm/boot/dts/am335x-evm.dts | 2 + arch/arm/boot/dts/am335x-evmsk.dts | 42 ++++++++-------- drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 10 +++- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 57 +++++++++++++++++----- drivers/gpu/drm/tilcdc/tilcdc_drv.h | 5 +- drivers/gpu/drm/tilcdc/tilcdc_external.c | 7 ++- drivers/gpu/drm/tilcdc/tilcdc_external.h | 2 +- drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 - drivers/gpu/drm/tilcdc/tilcdc_plane.c | 9 ++-- drivers/gpu/drm/tilcdc/tilcdc_regs.h | 14 ++++++ drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 2 - 13 files changed, 136 insertions(+), 49 deletions(-)
Signature · 1 line
1.9.1