improve initialization of genl handle
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | libgenl: introduce genl_init_handleinclude/ ip/ ip/ +4 more | +30 | 0 replies | |
| 2/4 | macsec: show usage even if the module is not availableip/ | +3 | 0 replies | |
| 3/4 | fou: show usage even if the module is not availableip/ | +6 | 0 replies | |
| 4/4 | ila: show usage even if the module is not availableip/ | +6 | 0 replies |
Reviews trailers per patch
None of the 4 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Phil Sutter |
|---|---|
| Series | A-b |
| 1/4 | |
| 2/4 | |
| 3/4 | |
| 4/4 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH iproute2 0/4] improve initialization of genl handle
This patchset fixes several issues for users of genetlink:
- Duplicated code for initialization of a genl handle. All users of genl must open a socket and resolve the family, and use the same code to do that.
Solution: add a library function.
- genl family resolution fails when the module that handles this family is not loaded yet.
This means that if we try to initialize the genl handle early in handling the command, we cannot display usage, because we fail hard when trying to resolve the genl family.
Solution: move the genl handle initialization after handling the ip * help case.
Sabrina Dubroca (4):
libgenl: introduce genl_init_handle
macsec: show usage even if the module is not available
fou: show usage even if the module is not available
ila: show usage even if the module is not available
include/libgenl.h | 2 ++ ip/ipfou.c | 20 ++++++-------------- ip/ipila.c | 19 ++++++------------- ip/ipl2tp.c | 12 ++---------- ip/ipmacsec.c | 20 +++----------------- ip/tcp_metrics.c | 14 +++----------- lib/libgenl.c | 17 +++++++++++++++++ 7 files changed, 39 insertions(+), 65 deletions(-)
Signature · 1 line
2.9.3