Skip to content

fix the issue that may copy duplicate addrs into assoc's bind address list

Xin Long linux-sctp netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 3 repliesIn review
  2. v12 patches 16 repliesSuperseded

Changes in v2 from the cover letter

Explain why we didn't filter the duplicate addresses when global address list gets updated in patch 2/2 changelog.

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2sctp: reduce indent level in sctp_copy_local_addr_listnet/sctp/protocol.c+19 -182 replies
2/2sctp: not copying duplicate addrs to the assoc's bind address listnet/sctp/bind_addr.c net/sctp/protocol.c+6 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchMarcelo Ricardo LeitnerNeil Horman
1/2A-b A-b
2/2A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCHv2 net 0/2] fix the issue that may copy duplicate addrs into assoc's bind address list

Patch 1/2 is to fix some indent level.

Given that we have kernels out there with this issue, patch 2/2 also fix sctp_raw_to_bind_addrs.

v1 -> v2:
Explain why we didn't filter the duplicate addresses when global address list gets updated in patch 2/2 changelog.

Xin Long (2):
sctp: reduce indent level in sctp_copy_local_addr_list
sctp: not copying duplicate addrs to the assoc's bind address list

 net/sctp/bind_addr.c |  3 +++
 net/sctp/protocol.c  | 40 ++++++++++++++++++++++------------------
 2 files changed, 25 insertions(+), 18 deletions(-)
Signature · 1 line
2.1.0