Skip to content

sctp: fix the transmit err process

Xin Long linux-sctp netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 2 repliesIn review
  2. v16 patches 10 repliesSuperseded

Changes in v2 from the cover letter

- add more details to the changelog in patch 1/6
- add Fixes: tag in patch 2/6, 3/6
- also revert 69b5777f2e57 in patch 3/6

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6sctp: remove the unnecessary state check in sctp_outq_tailnet/sctp/outqueue.c+14 -390 replies
2/6sctp: do not return the transmit err back to sctp_sendmsgnet/sctp/sm_sideeffect.c+5 -110 replies
3/6sctp: free msg->chunks when sctp_primitive_SEND return errinclude/net/sctp/structs.h net/sctp/chunk.c net/sctp/outqueue.c +1 more+20 -30 replies
4/6sctp: save transmit error to sk_err in sctp_outq_flushnet/sctp/output.c net/sctp/outqueue.c+14 -100 replies
5/6sctp: make sctp_outq_flush/tail/uncork return voidinclude/net/sctp/structs.h net/sctp/outqueue.c net/sctp/sm_sideeffect.c+13 -190 replies
6/6sctp: not return ENOMEM err back in sctp_packet_transmitnet/sctp/output.c+22 -250 replies

Reviews trailers per patch

None of the 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarcelo Ricardo Leitner
SeriesA-b
1/6
2/6
3/6
4/6
5/6
6/6

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCHv2 net 0/6] sctp: fix the transmit err process

This patchset is to improve the transmit err process and also fix some issues.

After this patchset, once the chunks are enqueued successfully, even if the chunks fail to send out, no matter because of nodst or nomem, no err retruns back to users any more. Instead, they are taken care of by retransmit.

v1->v2:
- add more details to the changelog in patch 1/6
- add Fixes: tag in patch 2/6, 3/6
- also revert 69b5777f2e57 in patch 3/6

Xin Long (6):
sctp: remove the unnecessary state check in sctp_outq_tail
sctp: do not return the transmit err back to sctp_sendmsg
sctp: free msg->chunks when sctp_primitive_SEND return err
sctp: save transmit error to sk_err in sctp_outq_flush
sctp: make sctp_outq_flush/tail/uncork return void
sctp: not return ENOMEM err back in sctp_packet_transmit

 include/net/sctp/structs.h |  5 +--
 net/sctp/chunk.c           | 13 +++++++
 net/sctp/output.c          | 50 +++++++++++++-------------
 net/sctp/outqueue.c        | 88 ++++++++++++++++------------------------------
 net/sctp/sm_sideeffect.c   | 25 +++++--------
 net/sctp/socket.c          |  8 +++--
 6 files changed, 85 insertions(+), 104 deletions(-)
Signature · 1 line
2.1.0