cleanup of xgifb/vb_setmode.c
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest6 patches 0 repliesNew
- v46 patches 1 replySuperseded
- v36 patches 2 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 6 patches | 6 replies | Superseded |
Changes in v5 from the cover letter
fix alignment in patch 6 such that the if-test arguments line up for better readability.
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | staging: xgifb: move AND operator for logical continuationdrivers/ | +4 | 0 replies | |
| 2/6 | staging: xgifb: remove unnecessary parenthesesdrivers/ | +16 | 0 replies | |
| 3/6 | staging: xgifb: remove blank line after open bracedrivers/ | +0 | 0 replies | |
| 4/6 | staging: xgifb: add spaces around |drivers/ | +1 | 0 replies | |
| 5/6 | staging: xgifb: remove blank line before closing bracedrivers/ | +0 | 0 replies | |
| 6/6 | staging: xgifb: fix alignment for if argumentsdrivers/ | +1 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [PATCH v5 0/6] cleanup of xgifb/vb_setmode.c
The following patchset contains patches to make the code more readable. This patchset fixes various issues that come up in the checkpatch in patch 1, 3, 4 and 5. Patches 2 and 6 are based on Julia's suggestion when a one patch was sent fixing the checkpatch issue of moving && operator to previous line.
---
Changes since v4:
fix alignment in patch 6 such that the if-test arguments line up for better readability.
Changes since v3:
fix commit messages in patches 2, 3 and 5 which exceeded 80 characters. Also, reworded patch 6 commit to explain the solution more clearly.
Changes since v2:
reword commit messages in all patches to explain the solution and using imperative form for the commit subject.
Changes since v1:
made a patchset instead of a patch to fix various readability issues in the code.
Gargi Sharma (6):
staging: xgifb: move AND operator for logical continuation
staging: xgifb: remove unnecessary parentheses
staging: xgifb: remove blank line after open brace
staging: xgifb: add spaces around |
staging: xgifb: remove blank line before closing brace
staging: xgifb: fix alignment for if arguments
drivers/staging/xgifb/vb_setmode.c | 49 ++++++++++++++------------------------ 1 file changed, 18 insertions(+), 31 deletions(-)
Signature · 1 line
2.9.2