Avoid race in perform_groupmems()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest1 patch 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/1 | useradd_base.bbclass: Do not mess with the gshadow file in the sysrootmeta/ | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/1] Avoid race in perform_groupmems()
We have seen sporadic failures in our CI builds due to useradd, groupadd or groupmems failing. I have now tracked it down to perform_groupmems() in useradd_base.bbclass, where I found code to temporarily create the /etc/gshadow file in the sysroot if it did not exist. Purportedly this was due to groupmems requiring the gshadow file to exist. There are, however, no real evidence of that requirement, and actually creating and removing the file the way it is currently done WILL cause failures when one task removes it while another task expects it to already exist.
//Peter
The following changes since commit 53b1fa2d3e1244c46a705d9a40ca0dbee92eab98:
bitbake: build: Allow dirs/cleandirs to work for empty functions (2016-09-15 12:15:07 +0100)
are available in the git repository at:
git://git.yoctoproject.org/poky-contrib pkj/groupmems
http://git.yoctoproject.org/cgit.cgi/poky-contrib/log/?h=pkj/groupmems
Peter Kjellerstedt (1):
useradd_base.bbclass: Do not mess with the gshadow file in the sysroot
meta/classes/useradd_base.bbclass | 12 ------------ 1 file changed, 12 deletions(-)
Signature · 1 line
2.9.0