Skip to content

x86/dumpstack: replace dump_trace() with a new unwinder

Josh Poimboeuf lkml 2 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 0 repliesNew
  2. v16 patches 1 replySuperseded

Changes in v2 from the cover letter

- rebase on latest tip
- remove NULL task pointer convention

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6x86/unwind: add new unwind interface and implementationsarch/x86/include/asm/unwind.h arch/x86/kernel/Makefile arch/x86/kernel/unwind_frame.c +1 more+215 -00 replies
2/6perf/x86: convert perf_callchain_kernel() to use the new unwinderarch/x86/events/core.c+10 -230 replies
3/6x86/stacktrace: convert save_stack_trace_*() to use the new unwinderarch/x86/kernel/stacktrace.c+29 -450 replies
4/6oprofile/x86: convert x86_backtrace() to use the new unwinderarch/x86/oprofile/backtrace.c+17 -220 replies
5/6x86/dumpstack: convert show_trace_log_lvl() to use the new unwinderarch/x86/include/asm/stacktrace.h arch/x86/kernel/dumpstack.c arch/x86/kernel/dumpstack_32.c +1 more+107 -471 reply
6/6x86/dumpstack: remove dump_trace() and related callbacksarch/x86/include/asm/stacktrace.h arch/x86/kernel/dumpstack.c arch/x86/kernel/dumpstack_32.c +1 more+0 -2260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/6] x86/dumpstack: replace dump_trace() with a new unwinder

v2:
- rebase on latest tip
- remove NULL task pointer convention

---

The last version was posted as part of a much larger patch set:

https://lkml.kernel.org/r/[email protected]

People complained about the set being too big, so it was split up into more digestible pieces. All the prerequisite patches for the unwinder have now been merged.

See patch 1/6 for the background and justification for this change.

Josh Poimboeuf (6):
x86/unwind: add new unwind interface and implementations perf/x86: convert perf_callchain_kernel() to use the new unwinder x86/stacktrace: convert save_stack_trace_*() to use the new unwinder oprofile/x86: convert x86_backtrace() to use the new unwinder x86/dumpstack: convert show_trace_log_lvl() to use the new unwinder x86/dumpstack: remove dump_trace() and related callbacks

 arch/x86/events/core.c            |  33 +++-----
 arch/x86/include/asm/stacktrace.h |  46 +----------
 arch/x86/include/asm/unwind.h     |  73 ++++++++++++++++
 arch/x86/kernel/Makefile          |   6 ++
 arch/x86/kernel/dumpstack.c       | 170 +++++++++++++++++---------------------
 arch/x86/kernel/dumpstack_32.c    |  44 +---------
 arch/x86/kernel/dumpstack_64.c    |  78 +----------------
 arch/x86/kernel/stacktrace.c      |  74 +++++++----------
 arch/x86/kernel/unwind_frame.c    |  93 +++++++++++++++++++++
 arch/x86/kernel/unwind_guess.c    |  43 ++++++++++
 arch/x86/oprofile/backtrace.c     |  39 ++++-----
 11 files changed, 357 insertions(+), 342 deletions(-)
 create mode 100644 arch/x86/include/asm/unwind.h
 create mode 100644 arch/x86/kernel/unwind_frame.c
 create mode 100644 arch/x86/kernel/unwind_guess.c
Signature · 1 line
2.7.4