Skip to content

Fixes, cleanup and g_NCR5380_mmio/g_NCR5380 merger

Finn Thain linux-arm-kernel linux-scsi lkml 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 6 repliesIn review
  2. v212 patches 2 repliesSuperseded
  3. v112 patches 2 repliesSuperseded

Changes in v3 from the cover letter

- added tested-by tags
- fixed typo in log message for patch 3/12

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12scsi/g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio driversMAINTAINERS drivers/scsi/Kconfig drivers/scsi/Makefile +3 more+134 -1950 replies
2/12scsi/cumana_1: Remove unused cumanascsi_setup() functiondrivers/scsi/arm/cumana_1.c+0 -41 reply
3/12scsi/atari_scsi: Make device register accessors re-entrantdrivers/scsi/atari_scsi.c+15 -30 replies
4/12scsi/ncr5380: Simplify register polling limitdrivers/scsi/NCR5380.c drivers/scsi/NCR5380.h+8 -70 replies
5/12scsi/ncr5380: Increase register polling limitdrivers/scsi/NCR5380.h+1 -10 replies
6/12scsi/ncr5380: Improve hostdata struct member alignment and cache-abilitydrivers/scsi/NCR5380.h+20 -200 replies
7/12scsi/ncr5380: Store IO ports and addresses in host private datadrivers/scsi/NCR5380.c drivers/scsi/NCR5380.h drivers/scsi/arm/cumana_1.c +6 more+118 -971 reply
8/12scsi/ncr5380: Use correct types for device register accessorsdrivers/scsi/NCR5380.c drivers/scsi/NCR5380.h drivers/scsi/arm/cumana_1.c +6 more+49 -781 reply
9/12scsi/ncr5380: Pass hostdata pointer to register polling routinesdrivers/scsi/NCR5380.c drivers/scsi/NCR5380.h drivers/scsi/mac_scsi.c+24 -250 replies
10/12scsi/ncr5380: Expedite register pollingdrivers/scsi/NCR5380.h drivers/scsi/arm/cumana_1.c drivers/scsi/atari_scsi.c+10 -32 replies
11/12scsi/ncr5380: Use correct types for DMA routinesdrivers/scsi/NCR5380.c drivers/scsi/NCR5380.h drivers/scsi/arm/cumana_1.c +7 more+176 -1141 reply
12/12scsi/ncr5380: Suppress unhelpful "interrupt without IRQ bit" messagedrivers/scsi/NCR5380.c+1 -10 replies

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by.

PatchHannes ReineckeMichael SchmitzOndrej ZaryRussell King
1/12R-b T-b
2/12R-b A-b
3/12R-b T-b
4/12R-b T-b T-b
5/12R-b T-b T-b
6/12R-b T-b T-b
7/12R-b T-b T-b A-b
8/12R-b T-b T-b A-b
9/12R-b T-b T-b
10/12R-b T-b T-b
11/12R-b T-b T-b A-b
12/12R-b T-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/12] Fixes, cleanup and g_NCR5380_mmio/g_NCR5380 merger

This patch series has fixes for compatibility, reliability and performance issues and some cleanup. It also includes a new version of Ondrej Zary's patch that merges g_NCR5380_mmio into g_NCR5380.

I've tested this patch series using mac_scsi on a Powerbook 180. Ondrej tested the g_NCR5380 driver and Michael tested atari_scsi. The other drivers have been compile-tested.

Changes since v1:
- rebased on 4.9/scsi-queue
- added reviewed-by tags
- tweaked the order of struct members in patch 7/12

Changes since v2:
- added tested-by tags
- fixed typo in log message for patch 3/12

Finn Thain (12):
scsi/g_NCR5380: Merge g_NCR5380 and g_NCR5380_mmio drivers scsi/cumana_1: Remove unused cumanascsi_setup() function scsi/atari_scsi: Make device register accessors re-entrant scsi/ncr5380: Simplify register polling limit scsi/ncr5380: Increase register polling limit scsi/ncr5380: Improve hostdata struct member alignment and
cache-ability
scsi/ncr5380: Store IO ports and addresses in host private data scsi/ncr5380: Use correct types for device register accessors scsi/ncr5380: Pass hostdata pointer to register polling routines scsi/ncr5380: Expedite register polling
scsi/ncr5380: Use correct types for DMA routines scsi/ncr5380: Suppress unhelpful "interrupt without IRQ bit" message

 MAINTAINERS                   |   1 -
 drivers/scsi/Kconfig          |  32 +----
 drivers/scsi/Makefile         |   1 -
 drivers/scsi/NCR5380.c        | 137 +++++++++++---------
 drivers/scsi/NCR5380.h        |  87 +++++++++----
 drivers/scsi/arm/cumana_1.c   |  98 +++++++-------
 drivers/scsi/arm/oak.c        |  34 +++--
 drivers/scsi/atari_scsi.c     |  77 ++++++-----
 drivers/scsi/dmx3191d.c       |  20 +--
 drivers/scsi/g_NCR5380.c      | 290 ++++++++++++++++++++----------------------
 drivers/scsi/g_NCR5380.h      |  32 +----
 drivers/scsi/g_NCR5380_mmio.c |  10 --
 drivers/scsi/mac_scsi.c       |  83 +++++-------
 drivers/scsi/sun3_scsi.c      |  80 ++++++------
 14 files changed, 495 insertions(+), 487 deletions(-)
 delete mode 100644 drivers/scsi/g_NCR5380_mmio.c
Signature · 1 line
2.7.3