Skip to content

openvswitch: make vlan handling consistent

Jiri Benc netdev 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest6 patches 2 repliesIn review
  2. v23 patches 9 repliesSuperseded

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6openvswitch: make skb modifiable in ovs_flow_key_extract*net/openvswitch/datapath.c net/openvswitch/flow.c net/openvswitch/flow.h +1 more+42 -220 replies
2/6openvswitch: normalize vlan rx pathnet/openvswitch/flow.c+22 -00 replies
3/6openvswitch: add NETIF_F_HW_VLAN_STAG_TX to internal devnet/openvswitch/vport-internal_dev.c+1 -10 replies
4/6openvswitch: keep vlan tag accelerated on internal devicenet/openvswitch/vport-internal_dev.c+7 -00 replies
5/6openvswitch: remove unreachable code in vlan parsingnet/openvswitch/flow.c+8 -200 replies
6/6openvswitch: fix vlan subtraction from packet lengthnet/openvswitch/vport.c+3 -70 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH net-next v3 0/6] openvswitch: make vlan handling consistent

Always keep the first vlan tag "accelerated", i.e. in skb->vlan_tci.

Unfortunately, with all the changes since v2, this patchset no longer has the nice deletions > insertions diffstat. I still think it's worth it, as it makes things more consistent overall.

Patch 3 is valid on its own. Patch 6 is needed in one form or other; with the changes in this set, it's a simple deletion. Otherwise we'd need more elaborate checks.

Jiri Benc (6):
openvswitch: make skb modifiable in ovs_flow_key_extract*
openvswitch: normalize vlan rx path
openvswitch: add NETIF_F_HW_VLAN_STAG_TX to internal dev
openvswitch: keep vlan tag accelerated on internal device
openvswitch: remove unreachable code in vlan parsing
openvswitch: fix vlan subtraction from packet length

 net/openvswitch/datapath.c           |  9 ++--
 net/openvswitch/flow.c               | 83 ++++++++++++++++++++++++------------
 net/openvswitch/flow.h               | 14 +++---
 net/openvswitch/vport-internal_dev.c |  9 +++-
 net/openvswitch/vport.c              | 18 +++-----
 5 files changed, 83 insertions(+), 50 deletions(-)
Signature · 1 line
1.8.3.1