allow non-trailers and multiple-line trailers
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest8 patches 2 repliesIn review
- v48 patches 10 repliesSuperseded
- v36 patches 11 repliesSuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 6 patches | 2 replies | Superseded | |
| v1 | 5 patches | 4 replies | Superseded |
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | trailer: improve const correctnesstrailer.c | +7 | 0 replies | |
| 2/8 | trailer: use list.h for doubly-linked listtrailer.c | +91 | 0 replies | |
| 3/8 | trailer: streamline trailer item create and addtrailer.c | +60 | 0 replies | |
| 4/8 | trailer: make args have their own structtrailer.c | +85 | 0 replies | |
| 5/8 | trailer: clarify failure modes in parse_trailertrailer.c | +53 | 0 replies | |
| 6/8 | trailer: allow non-trailers in trailer blockDocumentation/ t/ trailer.c | +194 | 0 replies | |
| 7/8 | trailer: forbid leading whitespace in trailersDocumentation/ t/ trailer.c | +17 | 0 replies | |
| 8/8 | trailer: support values folded to multiple linesDocumentation/ t/ trailer.c | +211 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [PATCH v5 0/8] allow non-trailers and multiple-line trailers
I've updated patch 5/8 to use strcspn and to pass in the list of separators, meaning that we no longer accept '=' in file input (and also updated its commit message accordingly).
We also discussed inlining find_separator, but after looking at the code, I think that it is more convenient if find_separator returns -1 when there is no separator, because of the 3 times it is used (as of 8/8), it is checked twice with '>= 1' (since both "no separator" and "string begins with separator" are handled in the same way - treating them as a non-trailer line). So I have left it as its own function.
No other updates.
Jonathan Tan (8):
trailer: improve const correctness
trailer: use list.h for doubly-linked list
trailer: streamline trailer item create and add
trailer: make args have their own struct
trailer: clarify failure modes in parse_trailer
trailer: allow non-trailers in trailer block
trailer: forbid leading whitespace in trailers
trailer: support values folded to multiple lines
Documentation/git-interpret-trailers.txt | 14 +- t/t7513-interpret-trailers.sh | 299 +++++++++++++++ trailer.c | 620 +++++++++++++++++-------------- 3 files changed, 654 insertions(+), 279 deletions(-)
Signature · 1 line
2.8.0.rc3.226.g39d4020