Skip to content

allow non-trailers and multiple-line trailers

Jonathan Tan git 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest8 patches 2 repliesIn review
  2. v48 patches 10 repliesSuperseded
  3. v36 patches 11 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v26 patches2 repliesSuperseded
v15 patches4 repliesSuperseded

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8trailer: improve const correctnesstrailer.c+7 -70 replies
2/8trailer: use list.h for doubly-linked listtrailer.c+91 -1670 replies
3/8trailer: streamline trailer item create and addtrailer.c+60 -700 replies
4/8trailer: make args have their own structtrailer.c+85 -500 replies
5/8trailer: clarify failure modes in parse_trailertrailer.c+53 -220 replies
6/8trailer: allow non-trailers in trailer blockDocumentation/git-interpret-trailers.txt t/t7513-interpret-trailers.sh trailer.c+194 -150 replies
7/8trailer: forbid leading whitespace in trailersDocumentation/git-interpret-trailers.txt t/t7513-interpret-trailers.sh trailer.c+17 -20 replies
8/8trailer: support values folded to multiple linesDocumentation/git-interpret-trailers.txt t/t7513-interpret-trailers.sh trailer.c+211 -100 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/8] allow non-trailers and multiple-line trailers

I've updated patch 5/8 to use strcspn and to pass in the list of separators, meaning that we no longer accept '=' in file input (and also updated its commit message accordingly).

We also discussed inlining find_separator, but after looking at the code, I think that it is more convenient if find_separator returns -1 when there is no separator, because of the 3 times it is used (as of 8/8), it is checked twice with '>= 1' (since both "no separator" and "string begins with separator" are handled in the same way - treating them as a non-trailer line). So I have left it as its own function.

No other updates.

Jonathan Tan (8):
trailer: improve const correctness
trailer: use list.h for doubly-linked list
trailer: streamline trailer item create and add
trailer: make args have their own struct
trailer: clarify failure modes in parse_trailer
trailer: allow non-trailers in trailer block
trailer: forbid leading whitespace in trailers
trailer: support values folded to multiple lines

 Documentation/git-interpret-trailers.txt |  14 +-
 t/t7513-interpret-trailers.sh            | 299 +++++++++++++++
 trailer.c                                | 620 +++++++++++++++++--------------
 3 files changed, 654 insertions(+), 279 deletions(-)
Signature · 1 line
2.8.0.rc3.226.g39d4020