Skip to content

Do some printk cleanups to avoid troubles with continuation lines

Mauro Carvalho Chehab linux-media 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest25 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/25tuner-xc2028: mark printk continuation lines as suchdrivers/media/tuners/tuner-xc2028.c+48 -450 replies
2/25tuner-xc2028: don't break long linesdrivers/media/tuners/tuner-xc2028.c+9 -140 replies
3/25em28xx: don't break long linesdrivers/media/usb/em28xx/em28xx-audio.c drivers/media/usb/em28xx/em28xx-cards.c drivers/media/usb/em28xx/em28xx-core.c +3 more+33 -540 replies
4/25em28xx: mark printk continuation lines as suchdrivers/media/usb/em28xx/em28xx-core.c+6 -60 replies
5/25em28xx: use pr_foo instead of em28xx-specific printk macrosdrivers/media/usb/em28xx/em28xx-audio.c drivers/media/usb/em28xx/em28xx-camera.c drivers/media/usb/em28xx/em28xx-cards.c +6 more+215 -2300 replies
6/25em28xx: convert the remaining printks to pr_foodrivers/media/usb/em28xx/em28xx-audio.c drivers/media/usb/em28xx/em28xx-camera.c drivers/media/usb/em28xx/em28xx-cards.c +6 more+146 -1670 replies
7/25dvb-core: don't break long linesdrivers/media/dvb-core/dvb_demux.c+1 -20 replies
8/25tuner-core: don't break long linesdrivers/media/v4l2-core/tuner-core.c+3 -40 replies
9/25tuner-core: use %&ph for small buffer dumpsdrivers/media/v4l2-core/tuner-core.c+3 -50 replies
10/25radio-bcm2048: don't ignore errorsdrivers/staging/media/bcm2048/radio-bcm2048.c+2 -00 replies
11/25dvb-core: use pr_foo() instead of printk()drivers/media/dvb-core/dmxdev.c drivers/media/dvb-core/dvb_ca_en50221.c drivers/media/dvb-core/dvb_demux.c +3 more+146 -1003 replies
12/25dvb_demux: convert an internal ifdef into a Kconfig optiondrivers/media/dvb-core/Kconfig drivers/media/dvb-core/dvb_demux.c+18 -90 replies
13/25dvb_demux: uncomment a packet loss check codedrivers/media/dvb-core/dvb_demux.c+6 -40 replies
14/25dvb-core: get rid of demux optional circular bufferdrivers/media/dvb-core/demux.h drivers/media/dvb-core/dmxdev.c drivers/media/dvb-core/dvb_demux.c +2 more+6 -500 replies
15/25dvb-core: move dvb_filter out of the DVB coredrivers/media/common/b2c2/flexcop-common.h drivers/media/dvb-core/Makefile drivers/media/pci/ttpci/Makefile +3 more+59 -70 replies
16/25dvb_filter: get rid of dead codedrivers/media/pci/ttpci/dvb_filter.c+0 -4850 replies
17/25dvb_filter: use KERN_CONT where neededdrivers/media/pci/ttpci/dvb_filter.c+6 -70 replies
18/25uvc_driver: use KERN_CONT where neededdrivers/media/usb/uvc/uvc_driver.c+15 -151 reply
19/25imon: use %*ph to do small hexa dumpsdrivers/media/rc/imon.c+2 -50 replies
20/25mt20xx: use %*ph to do small hexa dumpsdrivers/media/tuners/mt20xx.c+5 -160 replies
21/25tvaudio: mark printk continuation lines as suchdrivers/media/i2c/tvaudio.c+3 -20 replies
22/25flexcop-i2c: mark printk continuation lines as suchdrivers/media/common/b2c2/flexcop-i2c.c+5 -50 replies
23/25cx2341x: mark printk continuation lines as suchdrivers/media/common/cx2341x.c+6 -60 replies
24/25dvb-pll: use pr_foo() macros instead of printk()drivers/media/dvb-frontends/dvb-pll.c+12 -70 replies
25/25nxt6000: use pr_foo() macros instead of printk()drivers/media/dvb-frontends/nxt6000.c+76 -600 replies

Reviews trailers per patch

1 of 25 patches has a Reviewed-by or Acked-by.

PatchLaurent Pinchart
1/25
2/25
3/25
4/25
5/25
6/25
7/25
8/25
9/25
10/25
11/25
12/25
13/25
14/25
15/25
16/25
17/25
18/25R-b
19/25
20/25
21/25
22/25
23/25
24/25
25/25

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/25] Do some printk cleanups to avoid troubles with continuation lines

This commit:

	commit 563873318d328d9bbab4b00dfd835ac7c7e28697
	Merge: 24532f768121 bfd8d3f23b51
	Author: Linus Torvalds <[email protected]>
	Date:���Mon Oct 10 09:29:50 2016 -0700

	Merge branch 'printk-cleanups'

Affects dmesg prints like:

	printk(KERN_INFO "foo");
	printk(" bar\n);

Won't be doing the same output, as the Kernel won't understand the second printk as a continuation.

That's said, some media drivers use some very old driver-specific way of outputting messages, that came before pr_foo() and dev_foo() started being used at the subsystem.

This patch series start fixing those issues. I have another series of ~30-40 patches already, but they require more work, as they use dev_foo(), with could potentially cause some regression, and touch on a lot of drivers.

They also depend on a big patch that merges big printk lines, that I also want to split into smaller ones.

So, let me flush a series of cases that handle simpler cases.

Mauro Carvalho Chehab (25):
[media] tuner-xc2028: mark printk continuation lines as such [media] tuner-xc2028: don't break long lines
[media] em28xx: don't break long lines
[media] em28xx: mark printk continuation lines as such [media] em28xx: use pr_foo instead of em28xx-specific printk macros [media] em28xx: convert the remaining printks to pr_foo [media] dvb-core: don't break long lines
[media] tuner-core: don't break long lines
[media] tuner-core: use %&ph for small buffer dumps [media] radio-bcm2048: don't ignore errors
[media] dvb-core: use pr_foo() instead of printk() [media] dvb_demux: convert an internal ifdef into a Kconfig option [media] dvb_demux: uncomment a packet loss check code [media] dvb-core: get rid of demux optional circular buffer [media] dvb-core: move dvb_filter out of the DVB core [media] dvb_filter: get rid of dead code
[media] dvb_filter: use KERN_CONT where needed
[media] uvc_driver: use KERN_CONT where needed
[media] imon: use %*ph to do small hexa dumps
[media] mt20xx: use %*ph to do small hexa dumps
[media] tvaudio: mark printk continuation lines as such [media] flexcop-i2c: mark printk continuation lines as such [media] cx2341x: mark printk continuation lines as such [media] dvb-pll: use pr_foo() macros instead of printk() [media] nxt6000: use pr_foo() macros instead of printk()

 drivers/media/common/b2c2/flexcop-common.h         |   1 -
 drivers/media/common/b2c2/flexcop-i2c.c            |  10 +-
 drivers/media/common/cx2341x.c                     |  12 +-
 drivers/media/dvb-core/Kconfig                     |  13 +
 drivers/media/dvb-core/Makefile                    |   2 +-
 drivers/media/dvb-core/demux.h                     |   5 +-
 drivers/media/dvb-core/dmxdev.c                    |  28 +-
 drivers/media/dvb-core/dvb_ca_en50221.c            |  57 +-
 drivers/media/dvb-core/dvb_demux.c                 | 115 ++--
 drivers/media/dvb-core/dvb_demux.h                 |   2 -
 drivers/media/dvb-core/dvb_filter.c                | 603 ---------------------
 drivers/media/dvb-core/dvb_frontend.c              |  12 +-
 drivers/media/dvb-core/dvb_net.c                   |  85 +--
 drivers/media/dvb-core/dvbdev.c                    |  25 +-
 drivers/media/dvb-frontends/dvb-pll.c              |  19 +-
 drivers/media/dvb-frontends/nxt6000.c              | 136 +++--
 drivers/media/i2c/tvaudio.c                        |   5 +-
 drivers/media/pci/ttpci/Makefile                   |   2 +-
 drivers/media/pci/ttpci/dvb_filter.c               | 114 ++++
 drivers/media/{dvb-core => pci/ttpci}/dvb_filter.h |   0
 drivers/media/rc/imon.c                            |   7 +-
 drivers/media/tuners/mt20xx.c                      |  21 +-
 drivers/media/tuners/tuner-xc2028.c                | 116 ++--
 drivers/media/usb/em28xx/em28xx-audio.c            |  45 +-
 drivers/media/usb/em28xx/em28xx-camera.c           |  53 +-
 drivers/media/usb/em28xx/em28xx-cards.c            | 153 +++---
 drivers/media/usb/em28xx/em28xx-core.c             | 105 ++--
 drivers/media/usb/em28xx/em28xx-dvb.c              |  73 ++-
 drivers/media/usb/em28xx/em28xx-i2c.c              | 183 +++----
 drivers/media/usb/em28xx/em28xx-input.c            |  29 +-
 drivers/media/usb/em28xx/em28xx-vbi.c              |   7 +-
 drivers/media/usb/em28xx/em28xx-video.c            | 105 ++--
 drivers/media/usb/em28xx/em28xx.h                  |  18 +-
 drivers/media/usb/ttusb-dec/ttusb_dec.c            |  58 +-
 drivers/media/usb/uvc/uvc_driver.c                 |  30 +-
 drivers/media/v4l2-core/tuner-core.c               |  15 +-
 drivers/staging/media/bcm2048/radio-bcm2048.c      |   2 +
 37 files changed, 896 insertions(+), 1370 deletions(-)
 delete mode 100644 drivers/media/dvb-core/dvb_filter.c
 create mode 100644 drivers/media/pci/ttpci/dvb_filter.c
 rename drivers/media/{dvb-core => pci/ttpci}/dvb_filter.h (100%)
Signature · 1 line
2.7.4