Skip to content

Correct access to wrong BlockBackendPublic structures

Alberto Garcia qemu-devel 1 version Applied

Status from this message: Thanks, applied to the block branch.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2throttle: Correct access to wrong BlockBackendPublic structuresblock/throttle-groups.c+23 -41 reply
2/2qemu-iotests: Test I/O in a single drive from a throttling grouptests/qemu-iotests/093 tests/qemu-iotests/093.out+30 -70 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchPaolo Bonzini
1/2R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Qemu-devel] [PATCH 0/2] Correct access to wrong BlockBackendPublic structures

Hi all,

Paolo found that commit 27ccdd52598290f introduced a regression in the throttling code.

It can be easily reproduced in scenarios where you have a throttling group with several drives but you only write to one of them. In that case the round-robin algorithm can select the wrong drive all the time and the actual requests are never completed.

QEMU 2.7 is affected, here's the patch to fix it, plus a test case.

Thanks,

Berto

Alberto Garcia (2):
throttle: Correct access to wrong BlockBackendPublic structures
qemu-iotests: Test I/O in a single drive from a throttling group

 block/throttle-groups.c    | 27 +++++++++++++++++++++++----
 tests/qemu-iotests/093     | 33 ++++++++++++++++++++++++++++-----
 tests/qemu-iotests/093.out |  4 ++--
 3 files changed, 53 insertions(+), 11 deletions(-)
Signature · 1 line
2.9.3

Read the cover letter in its thread