Skip to content

drm/tilcdc: Cleanup tilcdc init sequence

Jyri Sarha dri-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest4 patches 5 repliesIn review
  2. v23 patches 2 repliesSuperseded
  3. v14 patches 30 repliesSuperseded

Changes in v3 from the cover letter

- Rebased on top of latest drm-next
- Add "drm/tilcdc: Fix race from forced shutdown of crtc in unload"

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4drm/tilcdc: Remove obsolete drm_connector_register() callsdrivers/gpu/drm/tilcdc/tilcdc_panel.c drivers/gpu/drm/tilcdc/tilcdc_tfp410.c+0 -40 replies
2/4drm/tilcdc: Stop using struct drm_driver load() callbackdrivers/gpu/drm/tilcdc/tilcdc_drv.c+70 -542 replies
3/4drm/tilcdc: Use unload to handle initialization failuresdrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+43 -713 replies
4/4drm/tilcdc: Fix race from forced shutdown of crtc in unloaddrivers/gpu/drm/tilcdc/tilcdc_crtc.c drivers/gpu/drm/tilcdc/tilcdc_drv.c drivers/gpu/drm/tilcdc/tilcdc_drv.h+26 -80 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchLaurent Pinchart
1/4R-b
2/4R-b
3/4
4/4

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCHv3 0/4] drm/tilcdc: Cleanup tilcdc init sequence

Since v2 version of this series:
- Rebased on top of latest drm-next
- Add "drm/tilcdc: Fix race from forced shutdown of crtc in unload"

Since first version of this series:
- Dropped "drm/i2c: tda998x: Remove obsolete drm_connector_register() call"
- an earlier instance of the same patch already exists
- Got rid of unload callback and deprecated drm_put_dev() calls

This series depends on tda998x dropping the drm_connector_register(). Please keep me in loop so that I know when it gets merged so that I know when it is safe send a pull request for these.

A patch[1] that crashed all drm drivers using load() hook was briefly part of linux-next, so became aware that tilcdc should stop using that too.

The two first patches should be merged before the third can be merged. So the merge order should be agreed with tda998x before going forward.

The last patch is just a cleanup, but depends on earlier ones.

Best regards,
Jyri

[1] https://patchwork.kernel.org/patch/9322771/

Jyri Sarha (4):
drm/tilcdc: Remove obsolete drm_connector_register() calls drm/tilcdc: Stop using struct drm_driver load() callback drm/tilcdc: Use unload to handle initialization failures drm/tilcdc: Fix race from forced shutdown of crtc in unload

 drivers/gpu/drm/tilcdc/tilcdc_crtc.c   |  35 +++++--
 drivers/gpu/drm/tilcdc/tilcdc_drv.c    | 185 +++++++++++++++------------------
 drivers/gpu/drm/tilcdc/tilcdc_drv.h    |   4 +-
 drivers/gpu/drm/tilcdc/tilcdc_panel.c  |   2 -
 drivers/gpu/drm/tilcdc/tilcdc_tfp410.c |   2 -
 5 files changed, 115 insertions(+), 113 deletions(-)
Signature · 6 lines
1.9.1

_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel