Skip to content

openvswitch: support for layer 3 encapsulated packets

Jiri Benc netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v13 Latest8 patches 6 repliesIn review

Changes in v13 from the cover letter

* Addressed Pravin's feedback.
* Removed the GRE vport conversion patch; L3 GRE ports should be created by rtnetlink instead.

Patches in v13 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8openvswitch: use hard_header_len instead of hardcoded ETH_HLENnet/openvswitch/actions.c net/openvswitch/vport.c+8 -50 replies
2/8openvswitch: add mac_proto field to the flow keynet/openvswitch/actions.c net/openvswitch/flow.c net/openvswitch/flow.h +1 more+31 -110 replies
3/8openvswitch: pass mac_proto to ovs_vport_sendnet/openvswitch/actions.c net/openvswitch/vport.c net/openvswitch/vport.h+19 -140 replies
4/8openvswitch: support MPLS push and pop for L3 packetsnet/openvswitch/actions.c+11 -70 replies
5/8openvswitch: add processing of L3 packetsnet/openvswitch/datapath.c net/openvswitch/flow.c net/openvswitch/vport.c+101 -371 reply
6/8openvswitch: netlink: support L3 packetsnet/openvswitch/flow_netlink.c+99 -610 replies
7/8openvswitch: add Ethernet push and pop actionsinclude/uapi/linux/openvswitch.h net/openvswitch/actions.c net/openvswitch/flow_netlink.c+82 -01 reply
8/8openvswitch: allow L3 netdev portsnet/openvswitch/vport-netdev.c+6 -30 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchPravin B Shelar
1/8A-b
2/8A-b
3/8A-b
4/8A-b
5/8A-b
6/8A-b
7/8A-b
8/8A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v13 thread

Cover letter [PATCH net-next v13 0/8] openvswitch: support for layer 3 encapsulated packets

At the core of this patch set is removing the assumption in Open vSwitch datapath that all packets have Ethernet header.

The implementation relies on the presence of pop_eth and push_eth actions in datapath flows to facilitate adding and removing Ethernet headers as appropriate. The construction of such flows is left up to user-space.

This series is based on work by Simon Horman, Lorand Jakab, Thomas Morin and others. I kept Lorand's and Simon's s-o-b in the patches that are derived from v11 to record their authorship of parts of the code.

Changes from v12 to v13:

* Addressed Pravin's feedback.
* Removed the GRE vport conversion patch; L3 GRE ports should be created by rtnetlink instead.

Main changes from v11 to v12:

* The patches were restructured and split differently for easier review.
* They were rebased and adjusted to the current net-next. Especially MPLS handling is different (and easier) thanks to the recent MPLS GSO rework.
* Several bugs were discovered and fixed. The most notable is fragment
handling: header adjustment for ARPHRD_NONE devices on tx needs to be done after refragmentation, not before it. This required significant changes in the patchset. Another one is stricter checking of attributes (match on L2 vs. L3 packet) at the kernel level.
* Instead of is_layer3 bool, a mac_proto field is used.

Jiri Benc (8):
openvswitch: use hard_header_len instead of hardcoded ETH_HLEN
openvswitch: add mac_proto field to the flow key
openvswitch: pass mac_proto to ovs_vport_send
openvswitch: support MPLS push and pop for L3 packets
openvswitch: add processing of L3 packets
openvswitch: netlink: support L3 packets
openvswitch: add Ethernet push and pop actions
openvswitch: allow L3 netdev ports

 include/uapi/linux/openvswitch.h |  15 ++++
 net/openvswitch/actions.c        | 111 +++++++++++++++++-------
 net/openvswitch/datapath.c       |  13 +--
 net/openvswitch/flow.c           | 105 +++++++++++++++++------
 net/openvswitch/flow.h           |  22 +++++
 net/openvswitch/flow_netlink.c   | 179 ++++++++++++++++++++++++++-------------
 net/openvswitch/vport-netdev.c   |   9 +-
 net/openvswitch/vport.c          |  31 +++++--
 net/openvswitch/vport.h          |   2 +-
 9 files changed, 353 insertions(+), 134 deletions(-)
Signature · 1 line
1.8.3.1